Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click info point dataset #1966

Merged
merged 1 commit into from May 20, 2016
Merged

Click info point dataset #1966

merged 1 commit into from May 20, 2016

Conversation

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented May 11, 2016

No description provided.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented May 11, 2016

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented May 12, 2016

@aashish24 @doutriaux1 Please review. Test results are at
https://open.cdash.org/index.php?compare1=63&filtercount=2&field1=buildname%2Fstring&project=UV-CDAT&field2=buildstarttime%2Fdate&showfilters=0&limit=100&compare2=83&value1=7483fc3c&showfeed=0&value2=20160511T213043
Note that for some reason, the correct baselines are not pulled by annie, so more tests are reported as failures that it should.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented May 16, 2016

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented May 16, 2016

two failures on my mac:

    115 - test_vcs_boxfill_robinson_wrap (Failed)
    432 - test_vcs_no_continents (Failed)

I'm not sure why it wasn't uploaded!

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented May 16, 2016

robinson is just a line that is not on top on mac, attaching the good (mac good)
test_robinson_wrap
file here

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented May 16, 2016

baseline missing for no continents?

432: vtkPNGReader (0x7fca2b623260): Unable to open file /Users/doutriaux1/build/uvcdat-testdata/baselines/vcs/test_vcs_no_continents.png

@danlipsa danlipsa force-pushed the click-info-point-dataset branch 2 times, most recently from 346f63c to ad82a5b May 17, 2016
@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented May 17, 2016

@doutriaux1 Is this ready? I think continents were fixed on master and I rebased. Not sure about test_vcs_boxfill_robinson_wrap. There seems to be a baseline without the top line.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented May 17, 2016

This is what fails on my machine:
54 - test_vcs_read_old_scr_2 (Failed)
65 - test_vcs_verify_boxfill_basics (Failed)
66 - test_vcs_verify_proj_basics (Failed)
67 - test_vcs_verify_fillarea_basics (Failed)
111 - test_vcs_canvas_background (Failed)
565 - diags_test_02 (Failed)
566 - diags_test_03 (Failed)
567 - diags_test_04 (Failed)
568 - diags_test_41 (Failed)
569 - diags_test_05 (Failed)
570 - diags_test_06 (Failed)
571 - diags_test_07 (Failed)
572 - diags_test_08 (Failed)
573 - diags_test_09 (Failed)
574 - diags_test_10 (Failed)
575 - diags_test_11 (Failed)
576 - diags_test_12 (Failed)
577 - diags_test_13 (Failed)
578 - diags_test_15 (Failed)

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented May 17, 2016

I think the first one is on me, I need to fix that. What about the other three?

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented May 17, 2016

@doutriaux1 The verify tests? They all say:
[~/projects/uvcdat/build]$ "/home/danlipsa/projects/uvcdat/build/install/bin/python" "/home/danlipsa/projects/uvcdat/src/testing/vcs/test_vcs_verify_boxfill_basics.py"
Traceback (most recent call last):
File "/home/danlipsa/projects/uvcdat/src/testing/vcs/test_vcs_verify_boxfill_basics.py", line 6, in
from vcs_test_common import *
ImportError: No module named vcs_test_common

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented May 17, 2016

@chaosphere2112 do you know why would that be?

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented May 17, 2016

@danlipsa Did you rerun cmake after testing @aashish24's branch?

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented May 18, 2016

@danlipsa can you rebase / update this branch on top of my testing branch?

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented May 18, 2016

@aashish24 @doutriaux1 Why not merge this branch into master as these failure are not related and happen on master as well. If @aashish24 testing branch fixes those, all the better.
I think a branch should have a focused goal, reach that and merge. We should not attempt to fix everything before we merge.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented May 18, 2016

@aashish24 @doutriaux1 Why not merge this branch into master

@danlipsa the only reason I was asking you to merge my branch since my branch has very large change and every time a new branch goes into master I have to make sure there is no conflict (size of the baselines, etc). Since I know for sure we are going to have conflict, that's why one of us would have to update. I just thought it would be easier for your branch since its small compare to mine but I am fine other way as well.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented May 18, 2016

@aashish24 I don't debate who should merge into master first. What I say is that we should test unrelated topics separately. If a topic is ready to merge it should be merged.
In this case I don't mind to wait for your topic to go in first.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented May 18, 2016

In this case I don't mind to wait for your topic to go in first.

That sounds great to me 👍, thanks for letting me finish first 🏃

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented May 18, 2016

@chaosphere2112 I removed CDAT-prefix, rerun cmake but I get the same failure. I remember seeing those on master as well at one point. Did you fix those?

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented May 18, 2016

@danlipsa I'm not clear what tests you're talking about at this point; I haven't done any work on any of the failing tests, pretty much ever. Not entirely clear why I got tagged in the first place, really 😄

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented May 18, 2016

@danlipsa danlipsa force-pushed the click-info-point-dataset branch from ad82a5b to 5375e79 May 20, 2016
@danlipsa danlipsa force-pushed the click-info-point-dataset branch from 5375e79 to 7a59926 May 20, 2016
@danlipsa danlipsa merged commit b5e67ac into master May 20, 2016
0 of 2 checks passed
@danlipsa danlipsa mentioned this pull request May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants