-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vcs fix geometry instantiation #1978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashish24
changed the title
Vcs fix geometry instantiation
[WIP] Vcs fix geometry instantiation
May 19, 2016
aashish24
force-pushed
the
vcs_fix_geometry_instantiation
branch
2 times, most recently
from
May 19, 2016 01:57
98488ed
to
125b042
Compare
Now:
|
aashish24
force-pushed
the
vcs_fix_geometry_instantiation
branch
2 times, most recently
from
May 19, 2016 15:45
98f9ece
to
956000d
Compare
aashish24
changed the title
[WIP] Vcs fix geometry instantiation
Vcs fix geometry instantiation
May 19, 2016
aashish24
force-pushed
the
vcs_fix_geometry_instantiation
branch
from
May 19, 2016 15:48
956000d
to
3d5aae8
Compare
@doutriaux1 @danlipsa this is ready for review as well. Just look at the last 2-3 commits (rest came from the other branch for testing). |
aashish24
force-pushed
the
vcs_fix_geometry_instantiation
branch
from
May 20, 2016 02:11
3d5aae8
to
dc86269
Compare
Do: test |
Do: test |
@aashish24 LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.