Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcs fix geometry instantiation #1978

Merged
merged 5 commits into from May 20, 2016
Merged

Vcs fix geometry instantiation #1978

merged 5 commits into from May 20, 2016

Conversation

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented May 19, 2016

No description provided.

@aashish24 aashish24 changed the title Vcs fix geometry instantiation [WIP] Vcs fix geometry instantiation May 19, 2016
@aashish24 aashish24 force-pushed the vcs_fix_geometry_instantiation branch 2 times, most recently from 98488ed to 125b042 May 19, 2016
@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented May 19, 2016

Now:

In [2]: import vcs

In [3]: x = vcs.init()

In [4]: x.geometry() # None

In [5]: x.geometry(100, 100)

In [6]: x.open()

In [7]: x.geometry(200, 100)

In [8]: x.geometry(200, 100)

In [9]: x.close()

In [10]: x.geometry()
Out[10]: {'height': 100, 'width': 200}

@aashish24 aashish24 force-pushed the vcs_fix_geometry_instantiation branch 2 times, most recently from 98f9ece to 956000d May 19, 2016
@aashish24 aashish24 changed the title [WIP] Vcs fix geometry instantiation Vcs fix geometry instantiation May 19, 2016
@aashish24 aashish24 force-pushed the vcs_fix_geometry_instantiation branch from 956000d to 3d5aae8 May 19, 2016
@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented May 19, 2016

@doutriaux1 @danlipsa this is ready for review as well. Just look at the last 2-3 commits (rest came from the other branch for testing).

@aashish24 aashish24 force-pushed the vcs_fix_geometry_instantiation branch from 3d5aae8 to dc86269 May 20, 2016
@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented May 20, 2016

Do: test

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented May 20, 2016

Do: test

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented May 20, 2016

@aashish24 LGTM.

@aashish24 aashish24 merged commit 9593283 into master May 20, 2016
0 of 2 checks passed
@aashish24 aashish24 deleted the vcs_fix_geometry_instantiation branch May 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants