Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Extend the isoline attribute list with the last value from the e… #2005

Merged
merged 1 commit into from Jun 2, 2016

Conversation

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Jun 2, 2016

…xisting attribute list

If there are no attributes in the list, we choose
default values: linewidth=1, linestyle='solid', linecolor='black'

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Jun 2, 2016

@@ -47,11 +53,19 @@ def _plotInternal(self):

if len(linewidth) < len(self._contourLevels):
# fill up the line width values
linewidth += [1.0] * (len(self._contourLevels) - len(linewidth))
if (len(linewidth) == 0):
Copy link
Contributor

@aashish24 aashish24 Jun 2, 2016

@danlipsa looks to me that this code is repetitive. Would it be useful to have a method in the same class?

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Jun 2, 2016

@aashish24 Great suggestion. See the revised code.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Jun 2, 2016

LGTM 👍 thanks for considering the suggestion.

…the existing attribute list

If there are no attributes in the list, we choose
default values: linewidth=1, linestyle='solid', linecolor='black'
@danlipsa danlipsa merged commit 69539a7 into master Jun 2, 2016
0 of 2 checks passed
@aashish24 aashish24 deleted the isoline-api branch Jun 2, 2016
@danlipsa danlipsa mentioned this pull request Jun 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants