New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Extend the isoline attribute list with the last value from the e… #2005

Merged
merged 1 commit into from Jun 2, 2016

Conversation

Projects
None yet
2 participants
@danlipsa
Contributor

danlipsa commented Jun 2, 2016

…xisting attribute list

If there are no attributes in the list, we choose
default values: linewidth=1, linestyle='solid', linecolor='black'

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Jun 2, 2016

@danlipsa danlipsa force-pushed the isoline-api branch from e30fdef to 80ecaad Jun 2, 2016

@@ -47,11 +53,19 @@ def _plotInternal(self):
if len(linewidth) < len(self._contourLevels):
# fill up the line width values
linewidth += [1.0] * (len(self._contourLevels) - len(linewidth))
if (len(linewidth) == 0):

This comment has been minimized.

@aashish24

aashish24 Jun 2, 2016

Contributor

@danlipsa looks to me that this code is repetitive. Would it be useful to have a method in the same class?

@danlipsa danlipsa force-pushed the isoline-api branch from 80ecaad to 607d6ea Jun 2, 2016

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Jun 2, 2016

@aashish24 Great suggestion. See the revised code.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jun 2, 2016

LGTM 👍 thanks for considering the suggestion.

BUG 1944: Extend the isoline attribute list with the last value from …
…the existing attribute list

If there are no attributes in the list, we choose
default values: linewidth=1, linestyle='solid', linecolor='black'

@danlipsa danlipsa force-pushed the isoline-api branch from 607d6ea to e7f1ea7 Jun 2, 2016

@danlipsa danlipsa merged commit 69539a7 into master Jun 2, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@aashish24 aashish24 deleted the isoline-api branch Jun 2, 2016

@danlipsa danlipsa referenced this pull request Jun 10, 2016

Closed

isofill vcs bug #1947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment