Proposed new color names #2065

aashish24 · 2016-07-27T15:03:24Z

No description provided.

aashish24 · 2016-07-27T15:05:46Z

@doutriaux1 @danlipsa I would like to propose refactoring the color names. The current color names unfortunately were inconsistent and hard to read. I followed the color names syntax as I found in some other tools specifically in R domain (https://www.nceas.ucsb.edu/~frazier/RSpatialGuides/colorPaletteCheatsheet.pdf) but I am open for suggestions. This in preparation for 3.0 release so, yes it will break the backward compatibility, but if you all insist, I can add a alias for now as well.

Also, over all the names got shorter, I deleted 277 characters and added 257.

Thoughts?

doutriaux1 · 2016-07-27T15:29:47Z

@aashish24 yes, let's add an alias. Also let's add matplotlib palettes especially viridis because I want to switch to viridis for our default in a separate PR.

doutriaux1 · 2016-07-27T15:30:21Z

@aashish24 I will add viridis and other matplotlib colormaps

aashish24 · 2016-07-27T15:45:18Z

@aashish24 I will add viridis and other matplotlib colormaps

@doutriaux1 if its okay, let me add that (and alias) so that we can have one branch for color maps.

aashish24 · 2016-07-27T15:46:13Z

thanks @doutriaux1 so sounds like these changes are liked which is great. I think it will really help boost vcs usability as we all are making the API better

doutriaux1 · 2016-07-27T15:46:31Z

i was going to do it in that branch but go ahead. Thanks!

aashish24 · 2016-07-27T15:46:47Z

i was going to do it in that branch but go ahead. Thanks!

roger that

aashish24 · 2016-08-05T06:05:43Z

@doutriaux1 @danlipsa this should be ready for review

aashish24 · 2016-08-05T06:12:37Z

Also, added matplotlib colors (plasma, inferno, magma, viridis)

doutriaux1 · 2016-08-05T14:29:59Z

Packages/vcs/vcs/Canvas.py

@@ -4961,6 +4979,15 @@ def setcolormap(self, name):
        #   updateVCSsegments_flag = args[1]
        # except:
        #   updateVCSsegments_flag = 1
+        # Python < 3 DeprecationWarning ignored by default


@aashish24 I don't think this should be here. We should issue this warning whenever the user sets the colormap instead.

thanks. @doutriaux1 I am bit confused. Currently the warning is in "setcolormap" instead. Look at the code at line 4953.

graphic methods can have colormaps as well, is that going to be triggered if I do:

import vcs b = vcs.createboxfill() b.colormap = "white_to_red"

remember there are 3 levels to look for the colormap used.
1- graphics method
2- canvas
3 vcs module

remember there are 3 levels to look for the colormap used.
1- graphics method
2- canvas
3 vcs module

Okay, let me add something to the code to make sure that we can map old to new regardless of where we set the colormap.

doutriaux1 · 2016-08-05T14:32:52Z

@aashish24 also the initial.attributes in Share is just ridiculously long, we should reformat it to a straight json dump.

doutriaux1 · 2016-08-05T14:34:24Z

@aashish24 let's also use this PR to switch the default colormap to viridis do you want me to do this?

aashish24 · 2016-08-05T21:04:49Z

@aashish24 also the initial.attributes in Share is just ridiculously long, we should reformat it to a straight json dump.

we could do that. I made a pass so that its pretty. Even though its long, its easy to read. I am fine either way.

aashish24 · 2016-08-05T21:05:16Z

@aashish24 let's also use this PR to switch the default colormap to viridis do you want me to do this?

@doutriaux1 okay if we do it in a separate PR to keep pr's small?

doutriaux1 · 2016-08-05T21:39:46Z

that's fine by me

aashish24 · 2016-08-07T03:56:46Z

@doutriaux1 I uglified the initial attributes as suggested, that made the file size three times smaller, I liked your idea, thanks. This branch is ready for review now.

aashish24 · 2016-08-09T14:23:33Z

@doutriaux1 @danlipsa @williams13 I am going to push one more change for backward compatibility and then this will be ready for review.

cdatrobot · 2016-08-09T14:23:40Z

Basic content checks passed!

Branch-at: 8e3fc58
Acked-by: @llnlbot

danlipsa · 2016-08-09T15:56:01Z

@aashish24 The new names LGTM 👍

sankhesh · 2016-08-09T15:58:21Z

Do: test

cdatrobot · 2016-08-09T15:58:23Z

Testing commands handed to buildbot.

Branch-at: 8e3fc58

kwrobot · 2016-08-09T15:58:29Z

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 8e3fc58

aashish24 · 2016-08-09T19:11:47Z

@doutriaux1 @danlipsa okay so I updated the code so that it will be backward compatible no matter how we set the colormap. Please have a look at the code now. Its ready for the review 🃏

cdatrobot · 2016-08-09T19:11:57Z

Basic content checks passed!

Changes since last check: compare

Branch-at: 89c3c52
Acked-by: @llnlbot

aashish24 · 2016-08-10T16:18:12Z

@doutriaux1 @danlipsa ping

danlipsa · 2016-08-10T16:56:35Z

@aashish24 LGTM 👍 i would squash the commits though

aashish24 · 2016-08-10T20:27:44Z

Do: test

cdatrobot · 2016-08-10T20:27:48Z

Testing commands handed to buildbot.

Branch-at: 89c3c52

cdatrobot · 2016-08-10T20:28:34Z

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 89c3c52

aashish24 · 2016-08-10T20:30:06Z

@aashish24 LGTM i would squash the commits though

@danlipsa each commit is different and brings new stuff to the code base. I am not entirely sure that in this particular case squashing makes sense. Actually if you look the branch there are only 4 commits as I rebased so the older commits are gone if that's what you were referring to.

danlipsa · 2016-08-10T22:05:31Z

@aashish24 Why would you have 'Added backward compatibility support' and 'Updated backward compatibility' as commits by themselves? Also, why would you have 'Proposed new color names' and 'Updated to use new color names' as separate commits?

doutriaux1 · 2016-08-11T01:47:11Z

@aashish24 does graphic_method.colormap = "old_name" issues the warning?

aashish24 · 2016-08-11T14:34:13Z

@aashish24 Why would you have 'Added backward compatibility support' and 'Updated backward compatibility' as commits by themselves? Also, why would you have 'Proposed new color names' and 'Updated to use new color names' as separate commits?

the first commit added the backward compatibility in a separate way which is different than the last commit on the same topic. I kept old to keep that history of what things I have tried. The proposed color names just added new names and the updated to use new color names updated tests to use new names vs the old ones. I am fine with squashing this into one.

aashish24 · 2016-08-11T14:36:06Z

@aashish24 does graphic_method.colormap = "old_name" issues the warning?

@doutriaux1 no it does not. I thought about it and I don't think with direct assignment like this we can issue a warning. Now we can issue a warning afterwards when we actually try to use the color name but it may not be as useful (especially since we user colormap at different places and very differently). Managing that could be lot of work. I think we document it and send an email to the mailing list that may suffice to inform the user but I am open for ideas.

doutriaux1 · 2016-08-11T14:53:32Z

@aashish24 it should be a property so you can issue the warning in the setter function

aashish24 · 2016-08-11T18:55:33Z

@aashish24 it should be a property so you can issue the warning in the setter function

I see that but then I guess I have to create a override function for all graphics method (there is no common baseclass?) Its more core (canvas and all other graphics methods etc..) but i am fine with that if that is more useful.

aashish24 · 2016-08-16T02:58:27Z

thanks @doutriaux1. I am wondering if we should have a base class for graphics methods. Thoughts? @doutriaux1 @danlipsa

doutriaux1 · 2016-08-16T13:50:06Z

I've been thinking about it for a while, there's something similar to that in vcsaddons, we should inspire ourselves from it.

* Proposed new color names * Added backward compatibility support * Updated to use new color names * Added perceptual sequential matplotlib colormap * Updated backward compatibility

aashish24 added this to the 3.0 milestone Jul 27, 2016

aashish24 force-pushed the vcs_color_names branch 2 times, most recently from b23aa8b to 2512eb0 Compare August 4, 2016 16:23

doutriaux1 reviewed Aug 5, 2016
View reviewed changes

aashish24 force-pushed the vcs_color_names branch from d9af7ac to a31dbc4 Compare August 7, 2016 03:48

aashish24 force-pushed the vcs_color_names branch from 00c7a66 to 018e8d7 Compare August 7, 2016 04:57

aashish24 added 4 commits August 7, 2016 01:05

Proposed new color names

9fedc80

Added backward compatibility support

f905764

Added perceptual sequential matplotlib colormap

46cd0de

Updated to use new color names

8e3fc58

aashish24 force-pushed the vcs_color_names branch from 018e8d7 to 8e3fc58 Compare August 7, 2016 05:05

Updated backward compatibility

89c3c52

aashish24 force-pushed the vcs_color_names branch from a2ea896 to 89c3c52 Compare August 9, 2016 19:10

Merge branch 'master' into vcs_color_names

39d9673

doutriaux1 merged commit 2fcf573 into master Aug 15, 2016

doutriaux1 deleted the vcs_color_names branch August 15, 2016 16:59

Proposed new color names #2065

Proposed new color names #2065

Conversation

aashish24 commented Jul 27, 2016

aashish24 commented Jul 27, 2016

doutriaux1 commented Jul 27, 2016

doutriaux1 commented Jul 27, 2016

aashish24 commented Jul 27, 2016

aashish24 commented Jul 27, 2016 • edited Loading

doutriaux1 commented Jul 27, 2016

aashish24 commented Jul 27, 2016

aashish24 commented Aug 5, 2016

aashish24 commented Aug 5, 2016

doutriaux1 Aug 5, 2016

Choose a reason for hiding this comment

aashish24 Aug 5, 2016

Choose a reason for hiding this comment

doutriaux1 Aug 5, 2016

Choose a reason for hiding this comment

doutriaux1 Aug 5, 2016

Choose a reason for hiding this comment

aashish24 Aug 9, 2016

Choose a reason for hiding this comment

doutriaux1 commented Aug 5, 2016

doutriaux1 commented Aug 5, 2016

aashish24 commented Aug 5, 2016

aashish24 commented Aug 5, 2016

doutriaux1 commented Aug 5, 2016

aashish24 commented Aug 7, 2016

aashish24 commented Aug 9, 2016 • edited Loading

cdatrobot commented Aug 9, 2016

danlipsa commented Aug 9, 2016

sankhesh commented Aug 9, 2016

cdatrobot commented Aug 9, 2016

kwrobot commented Aug 9, 2016

aashish24 commented Aug 9, 2016

cdatrobot commented Aug 9, 2016

aashish24 commented Aug 10, 2016

danlipsa commented Aug 10, 2016 • edited Loading

aashish24 commented Aug 10, 2016

cdatrobot commented Aug 10, 2016

cdatrobot commented Aug 10, 2016

aashish24 commented Aug 10, 2016

danlipsa commented Aug 10, 2016

doutriaux1 commented Aug 11, 2016 • edited Loading

aashish24 commented Aug 11, 2016

aashish24 commented Aug 11, 2016

doutriaux1 commented Aug 11, 2016

aashish24 commented Aug 11, 2016

aashish24 commented Aug 16, 2016

doutriaux1 commented Aug 16, 2016 • edited Loading

aashish24 commented Jul 27, 2016 •

edited

Loading

aashish24 commented Aug 9, 2016 •

edited

Loading

danlipsa commented Aug 10, 2016 •

edited

Loading

doutriaux1 commented Aug 11, 2016 •

edited

Loading

doutriaux1 commented Aug 16, 2016 •

edited

Loading