New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System dependent outline #2070

Merged
merged 3 commits into from Aug 2, 2016

Conversation

Projects
None yet
4 participants
@danlipsa
Contributor

danlipsa commented Aug 1, 2016

No description provided.

danlipsa added some commits Jul 29, 2016

BUG: Fix system dependent display of the outline of a dataset.
We increase the parallel projection parallelepiped with 1/1000 so that
it does not overlap with the outline of the dataset. This resulted in
system dependent display of the outline.
@kwrobot

This comment has been minimized.

Member

kwrobot commented Aug 1, 2016

Basic content checks passed!

Branch-at: 337bb70
Acked-by: @kwrobot

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 1, 2016

Baselines changes in:
CDAT/uvcdat-testdata#150

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 1, 2016

@doutriaux1 @aashish24 This fixes the system dependent showing of the top/bottom line for the outline. This was caused by the parallel projection parallelepiped having the same coordinates as the dataset outline. There is still system dependent label placement for isofill/isoline. Please review.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 1, 2016

@doutriaux1 @aashish24 The following tests fail on mac and linux - I have alternate baselines only for isofill/isoline + labels.
Linux
28 tests failed

The following tests FAILED:
13 - testWrite (Failed)
62 - test_vcs_read_old_scr_2 (Failed)
73 - test_vcs_verify_boxfill_basics (Failed)
121 - test_vcs_boxfill_decreasing_latitude (Failed)
122 - test_vcs_meshfill_no_wrapping (Failed)
413 - test_vcs_isofill_level0 (Failed)
414 - test_vcs_isofill_level1 (Failed)
415 - test_vcs_isofill_level2 (Failed)
469 - test_vcs_matplotlib_colormap (Failed)
549 - dv3d_vector_test (Failed)
550 - dv3d_slider_test (Failed)
551 - Hovmoller_volume_test (Failed)
552 - dv3d_volume_test (Failed)
553 - dv3d_constituents_test (Failed)
554 - dv3d_surface_test (Failed)
555 - dv3d_hovmoller_test (Failed)
580 - cdms2_test_createcopy_lose_dtype (Failed)
581 - CDMS_Test_01 (Failed)
582 - CDMS_Test_02 (Failed)
583 - CDMS_Test_03 (Failed)
584 - CDMS_Test_04 (Failed)
590 - CDMS_Test_10 (Failed)
598 - CDMS_Test_18 (Failed)
599 - CDMS_Test_20 (Failed)
602 - CDMS_Test_write_compressed (Failed)
606 - CDMS_Test_pack (Failed)
609 - CDMS_Test_write_extended_dimension (Failed)
610 - CDMS_Test_del_attributes (Failed)

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 1, 2016

@danlipsa the changes looks reasonable to me and looke like you deleted the extra baselines as they are no longer needed?

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 1, 2016

@aashish24 @doutriaux1 Indeed, the extra baseline is no longer needed for that extra line on the top. We still need an extra baseline for isoline/isofill + labels. I am not sure why we get different label positions on different platform - this is a different bug.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 1, 2016

These are the mac os x failed tests:
26 tests failed

The following tests FAILED:
3 - testMPIGrid (Failed)
4 - testAccuracy (Failed)
5 - testMarvel (Failed)
6 - testUnits (Failed)
7 - testRaynaud (Failed)
8 - testDateline (Failed)
9 - testEsmfInit4Pes (Failed)
17 - testMpi10Pes (Failed)
18 - testRemoteGet8Pes (Failed)
20 - testConserv (Failed)
21 - testEsmfVsLibcf (Failed)
22 - testEsmfInterface1 (Failed)
23 - testEsmfInterface2Pes (Failed)
24 - testDistArray6Pes (Failed)
25 - testGhostedDistArray6Pes (Failed)
26 - testEsmfGridToMeshRegridCsrv (Failed)
28 - testEsmf3DSmallesmf2Pes (Failed)
31 - testEsmfSmall2Pes (Failed)
32 - testEsmfSmall4Pes (Failed)
33 - testEsmfSmall8Pes (Failed)
35 - testTasRegrid2Pes (Failed)
46 - testEsmfSalinity2Pes (Failed)
47 - testEsmfSalinity4Pes (Failed)
48 - testEsmfSalinity8Pes (Failed)
52 - testDistSrc4Pes (Failed)
88 - test_vcs_verify_boxfill_basics (Failed)

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 1, 2016

Do: test

@kwrobot

This comment has been minimized.

Member

kwrobot commented Aug 1, 2016

Testing commands handed to buildbot.

Branch-at: 337bb70

@kwrobot

This comment has been minimized.

Member

kwrobot commented Aug 1, 2016

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 337bb70

@doutriaux1 doutriaux1 merged commit 54f2834 into master Aug 2, 2016

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
cdash
Details
default Basic content checks
kwrobot-branch-check Branch checks

@doutriaux1 doutriaux1 deleted the system-dependent-outline branch Aug 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment