New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with orthographic projection #2086

Merged
merged 1 commit into from Aug 16, 2016

Conversation

Projects
None yet
4 participants
@chaosphere2112
Contributor

chaosphere2112 commented Aug 11, 2016

This makes it so the centerlongitude attribute on orthographic projections actually works. Not entirely clear why the existing code didn't behave appropriately, "lon_0" is right according to the proj4 documentation, but this works right in VCS. Goes with CDAT/uvcdat-testdata#151

@cdatrobot

This comment has been minimized.

cdatrobot commented Aug 11, 2016

Basic content checks passed!

Branch-at: 636a24a
Acked-by: @llnlbot

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 16, 2016

LGTM 👍 Seems the issue was that CentralMeridian overwrote lon_0 that we were setting.

@danlipsa danlipsa merged commit c390fb6 into CDAT:master Aug 16, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
default Basic content checks
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 23, 2016

@chaosphere2112 test_center_longitude is missing frm repo

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 23, 2016

@chaosphere2112 wait for new baselines to be updated and then submit PR with corrected picture please.

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Aug 23, 2016

@doutriaux1 Yeah, it's missing from my hard drive as well. I'll rewrite the test and submit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment