New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 #2094

Merged
merged 1 commit into from Aug 22, 2016

Conversation

Projects
None yet
2 participants
@danlipsa
Contributor

danlipsa commented Aug 18, 2016

No description provided.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 18, 2016

@danlipsa danlipsa force-pushed the fix-master branch from a21f913 to 1e1a2e4 Aug 18, 2016

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 18, 2016

Do: test

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 18, 2016

@sankhesh The buildbot does not seem to get activated. Do you know why?

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 19, 2016

Do: check

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 19, 2016

Do: test

@cdatrobot

This comment has been minimized.

cdatrobot commented Aug 19, 2016

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 1e1a2e4

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 19, 2016

@chaosphere2112 Please review. The orthographic tests changes seem to be triggered by your fix. Did you run the tests when submitting the PR? I did merge it without asking. 😄

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 19, 2016

@chaosphere2112 @doutriaux1 @aashish24 Please review. Take a look at cdash - 26 tests failing compared with 31 on master.
#2092 (comment)

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Aug 19, 2016

@doutriaux1 Any chance we get the hd5 fix in master? 😄 Many of the 26 tests failing are caused by the hdf5 fix you already have. I suggest you merge only that or all your travis branch. (initially I posted this to the wrong PR)

@danlipsa danlipsa merged commit d700157 into master Aug 22, 2016

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
cdash
Details
llnlbot-branch-check Basic content checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment