Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG #1265: Fix datawc zoom-in for geographic projections. #2102

Merged
merged 2 commits into from Sep 13, 2016

Conversation

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Aug 23, 2016

No description provided.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Aug 23, 2016

@danlipsa danlipsa force-pushed the zoom_all_projections branch from 2e9ce0f to 4563678 Aug 23, 2016
@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Aug 23, 2016

Do: test

@cdatrobot
Copy link

@cdatrobot cdatrobot commented Aug 23, 2016

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 4563678

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Aug 23, 2016

@danlipsa the new baselines are looking pretty good but I would have to checkout them locally to see them all. Did we fix the cell issue?

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Aug 23, 2016

@aashish24 No. I did not. That is the issue:
#2099

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Aug 23, 2016

@sankhesh It seems that the buildbot is still picking up the wrong conda env:
https://open.cdash.org/testDetails.php?test=475842114&build=4516041

The commit is 4563678
but the conda env is
2.6-26-g2963743

@sankhesh
Copy link
Contributor

@sankhesh sankhesh commented Aug 23, 2016

Do: test

@cdatrobot
Copy link

@cdatrobot cdatrobot commented Aug 23, 2016

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 4563678

@danlipsa danlipsa force-pushed the zoom_all_projections branch from 4563678 to 0ea30f8 Aug 24, 2016
@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Aug 25, 2016

Do: test

@cdatrobot
Copy link

@cdatrobot cdatrobot commented Aug 25, 2016

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 0ea30f8

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 1, 2016

Do: test

@cdatrobot
Copy link

@cdatrobot cdatrobot commented Sep 1, 2016

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 66f32bd

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 1, 2016

@doutriaux1 @aashish24 This is ready to merge. buildbot is green.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 2, 2016

@doutriaux1 How do you restart travis if you only pushed uvcdat-testdata?

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 6, 2016

@danlipsa if you click on the details link, it takes you to travis page. From there if you log in using github credential a restart button appears. See picture. I restarted it for you.
restart travis

@danlipsa danlipsa force-pushed the zoom_all_projections branch from 66f32bd to 0d5654d Sep 7, 2016
@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 7, 2016

Do: test

@cdatrobot
Copy link

@cdatrobot cdatrobot commented Sep 7, 2016

Your merge request has been queued for testing. You may view the test results on CDash or Buildbot.

Branch-at: 0d5654d

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 8, 2016

@doutriaux1 @aashish24 All tests pass on both buildbot and travis. Take a look at the baselines changed and lets merge this.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 8, 2016

@danlipsa why would these test baseline changed? test_vcs_animate_isoline_text_labels

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 8, 2016

@aashish24 Because now the data is poly data instead of image data. I think this changed the label placement.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 13, 2016

@danlipsa what's the delay in merning this branch now? Are we waiting for more changes?

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 13, 2016

@aashish24 @doutriaux1 Just waiting for the go ahead.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 13, 2016

@doutriaux1 @aashish24 I'll merge it shortly ...

@danlipsa danlipsa merged commit e2f5e68 into master Sep 13, 2016
1 check was pending
@sankhesh sankhesh deleted the zoom_all_projections branch Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants