-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG #1265: Fix datawc zoom-in for geographic projections. #2102
Conversation
2e9ce0f
to
4563678
Compare
Do: test |
@danlipsa the new baselines are looking pretty good but I would have to checkout them locally to see them all. Did we fix the cell issue? |
@aashish24 No. I did not. That is the issue: |
@doutriaux1 @aashish24 Take a look at the following baselines for datawc (-30, 30, -50, 90) (30, -30, 90, -50) The whole dataset is |
@sankhesh It seems that the buildbot is still picking up the wrong conda env: The commit is 4563678 |
Do: test |
4563678
to
0ea30f8
Compare
Do: test |
0ea30f8
to
66f32bd
Compare
Do: test |
@doutriaux1 @aashish24 This is ready to merge. buildbot is green. |
@doutriaux1 How do you restart travis if you only pushed uvcdat-testdata? |
@danlipsa if you click on the |
66f32bd
to
0d5654d
Compare
Do: test |
@doutriaux1 @aashish24 All tests pass on both buildbot and travis. Take a look at the baselines changed and lets merge this. |
@danlipsa why would these test baseline changed? test_vcs_animate_isoline_text_labels |
@aashish24 Because now the data is poly data instead of image data. I think this changed the label placement. |
@danlipsa what's the delay in merning this branch now? Are we waiting for more changes? |
@aashish24 @doutriaux1 Just waiting for the go ahead. |
@doutriaux1 @aashish24 I'll merge it shortly ... |
No description provided.