Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcs3d record animation #739

Merged
merged 39 commits into from
Oct 6, 2014
Merged

Vcs3d record animation #739

merged 39 commits into from
Oct 6, 2014

Conversation

ThomasMaxwell
Copy link
Contributor

Facilitates running and saving animations of 2D data in vcs3D.
Adds uvcdat logo.

@doutriaux1
Copy link
Contributor

@potter2 @williams13 can you please confirm it works for you, the code change look good.

@potter2
Copy link

potter2 commented Oct 4, 2014

Confirm it by using Tom’s instructions?

Gerald (Jerry) Potter
NASA Goddard Space Flight Center
E-mail gerald.potter@nasa.gov
Office 28:S241
Phone 707.315.8314
Analysis and Data Consultant
Department GSFC:606.2

From: Charles <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Friday, October 3, 2014 at 6:08 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Gerald Potter <gerald.potter@nasa.govmailto:gerald.potter@nasa.gov>
Subject: Re: [uvcdat] Vcs3d record animation (#739)

@potter2https://github.com/potter2 @williams13https://github.com/williams13 can you please confirm it works for you, the code change look good.


Reply to this email directly or view it on GitHubhttps://github.com//pull/739#issuecomment-57890290.

@williams13
Copy link
Contributor

The colormap is not fixed! I changed the colormap in the GUI and nothing happened! I had to resize to see the colormap.

Are you sure everything was merged?!

From: Charles <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Friday, October 3, 2014 6:08 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Dean Williams <williams13@llnl.govmailto:williams13@llnl.gov>
Subject: Re: [uvcdat] Vcs3d record animation (#739)

@potter2https://github.com/potter2 @williams13https://github.com/williams13 can you please confirm it works for you, the code change look good.


Reply to this email directly or view it on GitHubhttps://github.com//pull/739#issuecomment-57890290.

@doutriaux1
Copy link
Contributor

@aahish24 I fixed this and @potter2 tested it. I will see what happen @williams13 I fixed it once I an fix it again

@williams13
Copy link
Contributor

Why aren't these fixes sticking? Why are we having to fix thing two or three times? That is the question..

From: Charles <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Friday, October 3, 2014 7:53 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Dean Williams <williams13@llnl.govmailto:williams13@llnl.gov>
Subject: Re: [uvcdat] Vcs3d record animation (#739)

@aahish24 I fixed this and @potter2https://github.com/potter2 tested it. I will see what happen @williams13https://github.com/williams13 I fixed it once I an fix it again


Reply to this email directly or view it on GitHubhttps://github.com//pull/739#issuecomment-57892754.

@aashish24
Copy link
Contributor

Folks, If @ThomasMaxwell branch started from an older master, then it would not have gotten the color map (which really is the update fix) fix. Please check the current master before further evaluation.

@aashish24
Copy link
Contributor

@doutriaux1 please see my email regarding this matter (I sent three emails on the subject before) and test the current master please.

@aashish24
Copy link
Contributor

@ThomasMaxwell do you have a separate branch for VCS 2D animation fix?

@@ -367,7 +462,7 @@ def processAnimationCommand( self, args, config_function = None ):
pass
elif args and args[0] == "InitConfig":
state = args[1]
bbar = self.getControlBar( 'Animation', [ ( "Step", "Run", "Stop" ), self.processAnimationStateChange ], mag=1.4 )
bbar = self.getControlBar( 'Animation', [ ( "Step", "Run", "Stop", ( "Record", True ) ), self.processAnimationStateChange ], mag=1.4 )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to wrap long line (more than 80+ characters)

aashish24 added a commit that referenced this pull request Oct 6, 2014
@aashish24 aashish24 merged commit 4da5c9e into master Oct 6, 2014
@aashish24 aashish24 deleted the vcs3D-record-animation branch October 6, 2014 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants