Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes missing GIT_PROTOCOL an error #833

Merged
merged 1 commit into from
Oct 22, 2014

Conversation

remram44
Copy link
Contributor

When this is hit, the project is NOT configured and you CANNOT build. Having cmake return 0 is wrong.

@remram44 remram44 added the Build label Oct 21, 2014
@remram44 remram44 added this to the 2.1 milestone Oct 21, 2014
set(GIT_PROTOCOL "git://" CACHE STRING "Choose protocol to be used by git" FORCE)
set_property(CACHE GIT_PROTOCOL PROPERTY STRINGS "git://" "http://")
return()
message(FATAL_ERROR "Select either git:// or http:// for checking out git submodules.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style we use uses [INFO] or [ERROR] in the message. Can you follow the same please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

When this is hit, the project is NOT configured and you CANNOT build.
Having cmake return 0 is wrong.
@aashish24
Copy link
Contributor

thanks. LGTM

aashish24 added a commit that referenced this pull request Oct 22, 2014
@aashish24 aashish24 merged commit 15c8b53 into CDAT:master Oct 22, 2014
@remram44 remram44 deleted the unset-git-protocol-error branch November 20, 2014 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants