New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes missing GIT_PROTOCOL an error #833

Merged
merged 1 commit into from Oct 22, 2014

Conversation

Projects
None yet
2 participants
@remram44
Contributor

remram44 commented Oct 21, 2014

When this is hit, the project is NOT configured and you CANNOT build. Having cmake return 0 is wrong.

@remram44 remram44 added the Build label Oct 21, 2014

@remram44 remram44 added this to the 2.1 milestone Oct 21, 2014

set(GIT_PROTOCOL "git://" CACHE STRING "Choose protocol to be used by git" FORCE)
set_property(CACHE GIT_PROTOCOL PROPERTY STRINGS "git://" "http://")
return()
message(FATAL_ERROR "Select either git:// or http:// for checking out git submodules.

This comment has been minimized.

@aashish24

aashish24 Oct 22, 2014

Contributor

The style we use uses [INFO] or [ERROR] in the message. Can you follow the same please?

This comment has been minimized.

@remram44

remram44 Oct 22, 2014

Contributor

Done!

Makes missing GIT_PROTOCOL an error
When this is hit, the project is NOT configured and you CANNOT build.
Having cmake return 0 is wrong.

@remram44 remram44 force-pushed the remram44:unset-git-protocol-error branch from 6611847 to 87d1d3a Oct 22, 2014

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Oct 22, 2014

thanks. LGTM

aashish24 added a commit that referenced this pull request Oct 22, 2014

Merge pull request #833 from remram44/unset-git-protocol-error
Makes missing GIT_PROTOCOL an error

@aashish24 aashish24 merged commit 15c8b53 into CDAT:master Oct 22, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@remram44 remram44 deleted the remram44:unset-git-protocol-error branch Nov 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment