New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcs3 d fix z axis problems #907

Merged
merged 7 commits into from Nov 20, 2014

Conversation

Projects
None yet
2 participants
@ThomasMaxwell
Contributor

ThomasMaxwell commented Nov 19, 2014

Jerry found a bug created by the name change from 'xyt' to 'Hovmoller3D' This branch fixes that error and should go into version 2.1. It also adds a Hovmoller test that catches this issue.

@ThomasMaxwell ThomasMaxwell added this to the 2.1 milestone Nov 19, 2014

@ThomasMaxwell ThomasMaxwell self-assigned this Nov 19, 2014

Update DV3DPlot.py
commenting out print statement
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Nov 19, 2014

ok @ThomasMaxwell looks good to me will run locally as we might run again into the picture not passing on ubuntu issue. If so will update the pix and approve.

@ThomasMaxwell

This comment has been minimized.

Contributor

ThomasMaxwell commented Nov 19, 2014

Thanks!

From: Charles Doutriaux <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, November 19, 2014 2:37 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: Re: [uvcdat] Vcs3 d fix z axis problems (#907)

ok @ThomasMaxwellhttps://github.com/ThomasMaxwell looks good to me will run locally as we might run again into the picture not passing on ubuntu issue. If so will update the pix and approve.


Reply to this email directly or view it on GitHubhttps://github.com//pull/907#issuecomment-63699600.

doutriaux1 added a commit that referenced this pull request Nov 20, 2014

Merge pull request #907 from UV-CDAT/vcs3D-fix_z_axis_problems
Vcs3 d fix z axis problems

ok tests pass on my ubuntu no need to update any files. Merging

@doutriaux1 doutriaux1 merged commit 78ddb17 into master Nov 20, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build could not complete due to an error
Details

@doutriaux1 doutriaux1 deleted the vcs3D-fix_z_axis_problems branch Nov 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment