New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vcs3 d fix animation exception #912

Merged
merged 2 commits into from Nov 24, 2014

Conversation

Projects
None yet
2 participants
@ThomasMaxwell
Contributor

ThomasMaxwell commented Nov 21, 2014

Fixes a couple of minor bugs discovered by Jerry. The animation would throw an (apparently harmless) exception if you hide the configure buttons while animating. And the initialization of the volume crop regions from scripts somehow got messed up, causing one of the ctests to fail.

@ThomasMaxwell ThomasMaxwell added this to the 2.1 milestone Nov 21, 2014

@ThomasMaxwell ThomasMaxwell self-assigned this Nov 21, 2014

@ThomasMaxwell ThomasMaxwell reopened this Nov 21, 2014

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 22, 2014

LGTM how do I reproduce the original bug and make sure it is solved by this branch?

aashish24 added a commit that referenced this pull request Nov 24, 2014

@aashish24 aashish24 merged commit 4176e6c into master Nov 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@aashish24 aashish24 deleted the vcs3D-fix-animation-exception branch Nov 24, 2014

@ThomasMaxwell

This comment has been minimized.

Contributor

ThomasMaxwell commented Nov 24, 2014

The dv3d_hovmoller_test should fail without the changes in this branch.

-- Tom

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Saturday, November 22, 2014 9:25 AM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: Re: [uvcdat] Vcs3 d fix animation exception (#912)

LGTM how do I reproduce the original bug and make sure it is solved by this branch?


Reply to this email directly or view it on GitHubhttps://github.com//pull/912#issuecomment-64081779.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment