Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error causing 3D plots to hang #940

Merged
merged 1 commit into from Dec 4, 2014
Merged

Conversation

@ThomasMaxwell
Copy link
Contributor

@ThomasMaxwell ThomasMaxwell commented Dec 2, 2014

No description provided.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 4, 2014

Almost looks good but will test and build just to make sure.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 4, 2014

@williams13 please wait for testing until I test this one.

@williams13
Copy link
Contributor

@williams13 williams13 commented Dec 4, 2014

Will do!

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Thursday, December 4, 2014 7:45 AM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Dean Williams <williams13@llnl.govmailto:williams13@llnl.gov>
Subject: Re: [uvcdat] Fix error causing 3D plots to hang (#940)

@williams13https://github.com/williams13 please wait for testing until I test this one.


Reply to this email directly or view it on GitHubhttps://github.com//pull/940#issuecomment-65651299.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 4, 2014

@ThomasMaxwell found one issue with this branch. Basically vcs_close test is now failing if I merge this one. I can see why. Can you look into it please?

@ThomasMaxwell
Copy link
Contributor Author

@ThomasMaxwell ThomasMaxwell commented Dec 4, 2014

I find that, with my branch merged, the 'vcs_test_close' ctest fails the first time it runs and then passes if you run it a second (or more) time(s). I did not implement this test and I don't know what it's doing, but its inconsistency suggests that there is something wrong with it. I would advise merging the branch so Dean and Jerry can continue their testing. Whoever wrote that ctest should take a look at it to see what's causing the problems.

-- Tom

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Thursday, December 4, 2014 12:23 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: Re: [uvcdat] Fix error causing 3D plots to hang (#940)

@ThomasMaxwellhttps://github.com/ThomasMaxwell found one issue with this branch. Basically vcs_close test is now failing if I merge this one. I can see why. Can you look into it please?


Reply to this email directly or view it on GitHubhttps://github.com//pull/940#issuecomment-65668254.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 4, 2014

Okay, that sounds reasonable to me. I can look at the test. The code you had most looked good to me.

aashish24 added a commit that referenced this issue Dec 4, 2014
@aashish24 aashish24 merged commit d21b3b7 into master Dec 4, 2014
1 check failed
@aashish24 aashish24 deleted the vcs3D-fix_3d_plot_hanging branch Dec 4, 2014
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Dec 4, 2014

@williams13 please test the current master.

@williams13
Copy link
Contributor

@williams13 williams13 commented Dec 5, 2014

Okay, I will give it a try now.

-Dean

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Thursday, December 4, 2014 1:52 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Dean Williams <williams13@llnl.govmailto:williams13@llnl.gov>
Subject: Re: [uvcdat] Fix error causing 3D plots to hang (#940)

@williams13https://github.com/williams13 please test the current master.


Reply to this email directly or view it on GitHubhttps://github.com//pull/940#issuecomment-65710323.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants