New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #960 #962

Merged
merged 1 commit into from Jan 14, 2015

Conversation

Projects
None yet
3 participants
@doutriaux1
Member

doutriaux1 commented Jan 14, 2015

@aashish24 @williams13 @dlonie please review so we can retag 2.1.0
don't forget to also approve associated baseline images pull request at:
CDAT/uvcdat-testdata#13
and check branch issue_960 of uvcdat-testdata when running ctest on this before merging
thanks.

fix #960
datwc was detrmined based on bounds whereas it should be for backward compatibility based on actual values if not set manually
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 14, 2015

also merge back in master after approving
thanks

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Jan 14, 2015

LGTM

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 14, 2015

I will merget this in release and master. Hang on

@aashish24 aashish24 merged commit 0106afa into release Jan 14, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@aashish24 aashish24 deleted the issue_960_bad_labels branch Jan 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment