New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build in source #973

Merged
merged 4 commits into from Jan 19, 2015

Conversation

Projects
None yet
4 participants
@allisonvacanti
Contributor

allisonvacanti commented Jan 19, 2015

Updated build in source test.

New PR is due to the old branch being in a fork (and thus not update-able by the team). #798 should be replaced by this PR.

This should go without saying, but please remain professional and respectful while discussing this patch. We're on the same team here -- I'd rather not see another issue history like #798.

remram44 and others added some commits Oct 10, 2014

Add testing for in-source build detection.
Modified function to detect symlinks / parent scopes and added a couple
of test cases.
@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Jan 19, 2015

@aashish24 @doutriaux1 @remram44

Added tests for functionality.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 19, 2015

LGTM 👍 I will just wait for Travis (as policy) and then will merge.. thanks

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 19, 2015

Looks like we are hitting the cmake version issue. I will push a separate fix for that.

aashish24 added a commit that referenced this pull request Jan 19, 2015

@aashish24 aashish24 merged commit 1f24e74 into master Jan 19, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@aashish24 aashish24 deleted the build-in-source branch Jan 19, 2015

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Jan 19, 2015

A while back I updated Girder's .travis.yml to update to the latest cmake. You can install from the binaries hosted at Kitware pretty easily. See here: girder/girder#564.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 21, 2015

@jbeezley thanks. We had it for Linux but not for OSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment