Build in source #973
Merged
Build in source #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified function to detect symlinks / parent scopes and added a couple of test cases.
|
@aashish24 @doutriaux1 @remram44 Added tests for functionality. |
|
LGTM 👍 I will just wait for Travis (as policy) and then will merge.. thanks |
|
Looks like we are hitting the cmake version issue. I will push a separate fix for that. |
|
A while back I updated Girder's |
|
@jbeezley thanks. We had it for Linux but not for OSX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated build in source test.
New PR is due to the old branch being in a fork (and thus not update-able by the team). #798 should be replaced by this PR.
This should go without saying, but please remain professional and respectful while discussing this patch. We're on the same team here -- I'd rather not see another issue history like #798.