New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake to version 3.1 on travis before building #975

Merged
merged 4 commits into from Jan 21, 2015

Conversation

Projects
None yet
3 participants
@jbeezley
Contributor

jbeezley commented Jan 20, 2015

Should fix the cmake_minimum_required errors.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 20, 2015

@jbeezley the mac build still fails, probably because you're only looking for "linux" could you please also add th bits for Mac? Or is Mac failing for some othe reason?

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Jan 20, 2015

I'm not familiar with the build environment for mac, but I could do the same if the cmake is too old. I believe the mac test failure is unrelated to this though.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 20, 2015

If think mac is even more sensitive to CMake version than Linux so it might be worth doing it always no matter which OS (maybe test for Travis' CMake version first though)

jbeezley added some commits Jan 20, 2015

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Jan 20, 2015

It looks like the osx build uses homebrew cmake at version 3.0.2. I added a line to upgrade to 3.1 via homebrew.

.travis.yml Outdated
@@ -6,6 +6,9 @@ language: c++
before_install:
- if [ "$TRAVIS_OS_NAME" = "linux" ]; then sudo apt-get update -qq; sudo add-apt-repository ppa:kubuntu-ppa/beta -y; sudo apt-get update; sudo apt-get install -y cmake; sudo apt-get install -y gfortran; fi

This comment has been minimized.

@aashish24

aashish24 Jan 21, 2015

Contributor

We should then get rid of cmake install here

- if [ "$TRAVIS_OS_NAME" = "linux" ]; then sudo apt-get update -qq; sudo apt-get install -y gfortran; fi
- if [ "$TRAVIS_OS_NAME" = "linux" ]; then pushd $HOME && mkdir cmake3.1 && cd cmake3.1 && (curl "http://www.cmake.org/files/v3.1/cmake-3.1.0-Linux-x86_64.tar.gz" | gunzip -c | tar x) && cd cmake-*/bin && export PATH="${PWD}:${PATH}"; popd; fi
- if [ "$TRAVIS_OS_NAME" = "osx" ]; then brew update ; brew outdated cmake || brew upgrade cmake ; fi
- cmake --version

This comment has been minimized.

@aashish24

aashish24 Jan 21, 2015

Contributor

Not sure what this line would do? It won't console output I think.. (could be wrong though)

This comment has been minimized.

@jbeezley

jbeezley Jan 21, 2015

Contributor

Yes, you can see it in the travis output.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 21, 2015

Other than that.. LGTM. Merging.

aashish24 added a commit that referenced this pull request Jan 21, 2015

Merge pull request #975 from UV-CDAT/travis-cmake
Update cmake to version 3.1 on travis before building

@aashish24 aashish24 merged commit 1b1df0f into master Jan 21, 2015

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@aashish24 aashish24 deleted the travis-cmake branch Jan 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment