Update cmake to version 3.1 on travis before building #975
Conversation
|
@jbeezley the mac build still fails, probably because you're only looking for "linux" could you please also add th bits for Mac? Or is Mac failing for some othe reason? |
|
I'm not familiar with the build environment for mac, but I could do the same if the cmake is too old. I believe the mac test failure is unrelated to this though. |
|
If think mac is even more sensitive to CMake version than Linux so it might be worth doing it always no matter which OS (maybe test for Travis' CMake version first though) |
|
It looks like the osx build uses homebrew cmake at version 3.0.2. I added a line to upgrade to 3.1 via homebrew. |
| @@ -6,6 +6,9 @@ language: c++ | |||
|
|
|||
| before_install: | |||
| - if [ "$TRAVIS_OS_NAME" = "linux" ]; then sudo apt-get update -qq; sudo add-apt-repository ppa:kubuntu-ppa/beta -y; sudo apt-get update; sudo apt-get install -y cmake; sudo apt-get install -y gfortran; fi | |||
There was a problem hiding this comment.
We should then get rid of cmake install here
| - if [ "$TRAVIS_OS_NAME" = "linux" ]; then sudo apt-get update -qq; sudo apt-get install -y gfortran; fi | ||
| - if [ "$TRAVIS_OS_NAME" = "linux" ]; then pushd $HOME && mkdir cmake3.1 && cd cmake3.1 && (curl "http://www.cmake.org/files/v3.1/cmake-3.1.0-Linux-x86_64.tar.gz" | gunzip -c | tar x) && cd cmake-*/bin && export PATH="${PWD}:${PATH}"; popd; fi | ||
| - if [ "$TRAVIS_OS_NAME" = "osx" ]; then brew update ; brew outdated cmake || brew upgrade cmake ; fi | ||
| - cmake --version |
There was a problem hiding this comment.
Not sure what this line would do? It won't console output I think.. (could be wrong though)
There was a problem hiding this comment.
Yes, you can see it in the travis output.
|
Other than that.. LGTM. Merging. |
Update cmake to version 3.1 on travis before building
Should fix the
cmake_minimum_requirederrors.