New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative path somehow got broken #982

Merged
merged 1 commit into from Jan 27, 2015

Conversation

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Jan 26, 2015

full path seems to work and the patch anyway tries to convert relpath back to full path
fix #981
@dlonie @aashish24 please review and merge.

relative path somehow got broken
full path seems to work and the patch anyway tries to convert relpath back to full path
fix #981

@doutriaux1 doutriaux1 added this to the 2.1.1 milestone Jan 26, 2015

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Jan 27, 2015

lgtm (Travis failure is due to #977 / #978).

The relative was likely there to support having a relocatable UVCDAT installation. I don't think that's supported anyway, so it shouldn't harm anything at the moment.

allisonvacanti added a commit that referenced this pull request Jan 27, 2015

Merge pull request #982 from UV-CDAT/issue_981_esmf_broken
relative path somehow got broken

@allisonvacanti allisonvacanti merged commit 53f5376 into master Jan 27, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@doutriaux1 doutriaux1 deleted the issue_981_esmf_broken branch Mar 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment