Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative path somehow got broken #982

Merged
merged 1 commit into from Jan 27, 2015
Merged

relative path somehow got broken #982

merged 1 commit into from Jan 27, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Jan 26, 2015

full path seems to work and the patch anyway tries to convert relpath back to full path
fix #981
@dlonie @aashish24 please review and merge.

full path seems to work and the patch anyway tries to convert relpath back to full path
fix #981
@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jan 27, 2015

lgtm (Travis failure is due to #977 / #978).

The relative was likely there to support having a relocatable UVCDAT installation. I don't think that's supported anyway, so it shouldn't harm anything at the moment.

allisonvacanti pushed a commit that referenced this issue Jan 27, 2015
relative path somehow got broken
@allisonvacanti allisonvacanti merged commit 53f5376 into master Jan 27, 2015
1 check failed
@doutriaux1 doutriaux1 deleted the issue_981_esmf_broken branch Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants