New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #984 #985

Merged
merged 1 commit into from Jan 28, 2015

Conversation

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Jan 28, 2015

criteriaargclim was messing up criteriaarg and useless
commented out, probably should take all code out, but in case of 'custom' criteria func it might be usefull
so letting it in

fix #984
criteriaargclim was messing up criteriaarg and useless
commented out, probably should take all code out, but in case of 'custom' criteria func it might be usefull
so letting it in
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jan 28, 2015

@dlonie @aashish24 @painter1 this is a tiny fix to a HUGE problem for diags test suite please review and merge as soon as possible we need this for ACME project.
@painter1 in the mean time you can comment out the line on your builds.

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Jan 28, 2015

LGTM

allisonvacanti added a commit that referenced this pull request Jan 28, 2015

@allisonvacanti allisonvacanti merged commit 804abe8 into master Jan 28, 2015

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@doutriaux1 doutriaux1 deleted the issue_984_criteriaargclim branch Mar 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment