New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting the correct PYTHON_SITE_PACKAGES_PREFIX on Apple #988

Merged
merged 4 commits into from Jan 29, 2015

Conversation

Projects
None yet
4 participants
@jbeezley
Contributor

jbeezley commented Jan 28, 2015

This will hopefully fix the latest Apple build failures.

@jbeezley jbeezley referenced this pull request Jan 29, 2015

Closed

mac build broken #991

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 29, 2015

@jbeezley what version of Mac you tested this against?

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Jan 29, 2015

I have 10.10, but it also fixes the travis build. The problem it fixes should be independent of the OS version AFAIK.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 29, 2015

Interesting. Are you using 10.10 SDK? Or is it finding the 10.9 SDK (check you cache file please). Iwill be curious.

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Jan 29, 2015

Well, both I guess.

$ grep SDK CMakeCache.txt 
CMAKE_OSX_SYSROOT:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.sdk
CURL_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include
LIBXML2_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/libxml2
LIBXSLT_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include
READLINE_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/readline
UUID_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/uuid
ZLIB_INCLUDE_DIR:PATH=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include
FIND_PACKAGE_MESSAGE_DETAILS_LibXml2:INTERNAL=[/usr/lib/libxml2.dylib][/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/libxml2][v2.9.0()]
FIND_PACKAGE_MESSAGE_DETAILS_LibXslt:INTERNAL=[/usr/lib/libxslt.dylib][/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include][v1.1.28()]
FIND_PACKAGE_MESSAGE_DETAILS_READLINE:INTERNAL=[/usr/lib/libreadline.dylib][/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/readline][v()]
FIND_PACKAGE_MESSAGE_DETAILS_UUID:INTERNAL=[/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include/uuid][v()]
FIND_PACKAGE_MESSAGE_DETAILS_ZLIB:INTERNAL=[/usr/lib/libz.dylib][/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/usr/include][v1.2.5()]
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jan 29, 2015

Makes sense. We don't have a pure 10.10 build. Other than that it looks good.

@remram44

This comment has been minimized.

Contributor

remram44 commented on 03e3a6b Jan 29, 2015

Couldn't the if be one line earlier so that you don't repeat line 17=20?

This comment has been minimized.

Contributor

jbeezley replied Jan 29, 2015

Sure, revised in latest commit.

jbeezley and others added some commits Jan 29, 2015

updated get_prefix
with system python branch from @2ashish24 things get installed somewhere else now on Mac
this catches it and fix error on json from vcs

doutriaux1 added a commit that referenced this pull request Jan 29, 2015

Merge pull request #988 from UV-CDAT/fix-pythonpath-apple
Setting the correct PYTHON_SITE_PACKAGES_PREFIX on Apple

@doutriaux1 doutriaux1 merged commit 265324f into master Jan 29, 2015

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details
@remram44

This comment has been minimized.

Contributor

remram44 commented on cd3f51e Jan 29, 2015

The two %is are inside a formatted block and need to be escaped as %%i. Really, this is bad code and it will keep breaking. See #882.

This comment has been minimized.

Member

doutriaux1 replied Jan 29, 2015

nice catch! That will teach me to copy paste! Fixing right away

This comment has been minimized.

Member

doutriaux1 replied Jan 29, 2015

And yes it's bad and old code (even older than me!). We've been through this. Feel free to improve if it bothers you that much 😉

@doutriaux1 doutriaux1 deleted the fix-pythonpath-apple branch Mar 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment