-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated packages reference #992
Conversation
For the uvcmetrics, I have followed what is suggested by Jeff and Brian.
Aashish the PACKAGE_MD5 is used to generate the file that says which version of which package have been generated, can you please make sure this is still correct? Thanks |
also where o you set the _BRANCH tags in the .pkg files? Did you edit them earlier? I don't see them in the list of changed files. |
PACKAGE_MD5 for these packages are used just as it a branch name. I run a grep and I couldn't find any other use. Do you not see VISTRAILS_BRANCH and PARAVIEW_BRANCH? |
Going once.. going twice... going... -:) |
@aashish24 this bit will be broken:
|
Thanks. I can push a fix for it. Basically, we can do a check and then construct the pacakge info. |
Pushed a fix. Please review again @doutriaux1 |
lgtm building on my system and then merging. |
Great.. once this goes in, I can update the VTK as well. |
i don't know if that's yours and something that went into master (merged master locally in before running your PR), but now this happens:
sourcing messes up my prompt. Not quite sure what's going on here. Let me build pure master and if also happens then I can at least approve this. |
i really don't see how this could mess my prompt, it must be something that went into master. |
ok commit b0d5230 introduces this prompt change! merging this but going to promptly (haha) ask to reverse that prompt change, who approved this? |
For the uvcmetrics, I have followed what is suggested by Jeff
and Brian.