Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regrid2 vertical regridder seems broken #15

Closed
doutriaux1 opened this issue Oct 12, 2016 · 5 comments
Closed

regrid2 vertical regridder seems broken #15

doutriaux1 opened this issue Oct 12, 2016 · 5 comments
Assignees
Milestone

Comments

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Oct 12, 2016

see commented out lines in test_regrid2.py

line 98, line 112,

@dnadeau4 dnadeau4 added this to the 3.0 milestone Oct 12, 2016
@dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Nov 3, 2016

@dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Apr 21, 2017

missing_value was set to [1] in tvariable by default

Assert that fill_value is set depending of dtype

        if dtype is None and data is not None:
            dtype = numpy.array(data).dtype
        if fill_value is not None:
            fill_value = numpy.array(fill_value).astype(dtype)
        else:
            fill_value = numpy.ma.MaskedArray(1).astype(dtype).item()
            fill_value = numpy.ma.default_fill_value(fill_value)

@dnadeau4 dnadeau4 mentioned this issue Apr 21, 2017
@dnadeau4 dnadeau4 closed this Apr 21, 2017
@doutriaux1 doutriaux1 reopened this Apr 24, 2017
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Apr 24, 2017

@dnadeau4 the PR is closed but not merged. Re-opening until this is clarified.

@dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Apr 26, 2017

This was fill value issue that I fixed. The comment I used fix closed the issue automatically.

@dnadeau4 dnadeau4 closed this Sep 29, 2017
@dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Sep 29, 2017

This must be fixed and merged at this time. They are no more commented lines in test_regrid2.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants