Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdsm2 createGenericGrid need to be generic #5

Closed
dnadeau4 opened this issue Sep 12, 2016 · 4 comments
Closed

cdsm2 createGenericGrid need to be generic #5

dnadeau4 opened this issue Sep 12, 2016 · 4 comments
Assignees
Milestone

Comments

@dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Sep 12, 2016

From @doutriaux1 on August 9, 2016 16:18

f2=  cdms2.open(fnmcurv)
In [4]: s=f2("sample")
In [5]: g=s.getGrid()
In [6]: lat = g.getLatitude()
In [7]: lon=g.getLongitude()
In [9]: g2 = cdms2.createGenericGrid(lat,lon)
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-9-da081e424d79> in <module>()
----> 1 g2 = cdms2.createGenericGrid(lat,lon)

Copied from original issue: CDAT/cdat#2081

@dnadeau4 dnadeau4 self-assigned this Sep 12, 2016
@dnadeau4 dnadeau4 added the cdms2 label Sep 12, 2016
@dnadeau4
Copy link
Contributor Author

@dnadeau4 dnadeau4 commented Sep 12, 2016

From @doutriaux1 on August 9, 2016 16:20

Out[10]: '/home/doutriaux1/miniconda2/envs/Test/share/uvcdat/sample_data/sampleCurveGrid4.nc'

@dnadeau4
Copy link
Contributor Author

@dnadeau4 dnadeau4 commented Apr 21, 2017

@doutriaux1 please revise pull request #119

@durack1
Copy link
Member

@durack1 durack1 commented Apr 21, 2017

@dnadeau4 while you're looking at grids the CDAT/cdat#1707 and #42 should also get a look

@dnadeau4 dnadeau4 mentioned this issue Apr 21, 2017
@dnadeau4 dnadeau4 closed this Apr 21, 2017
@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Apr 24, 2017

@dnadeau4 please refrain to close before PR is in. Thanks.

doutriaux1 added a commit that referenced this issue Apr 26, 2017
* fix #5 create Generic Grid for curvilinear grid

* delete print

* add bounds testing using assertTrue

* remove import pdb from test
dnadeau4 added a commit that referenced this issue May 1, 2017
* fix #5 create Generic Grid for curvilinear grid

* delete print

* add bounds testing using assertTrue

* fix#15 regrid2 with wrong default fill_value

* fix test changing Regridder to Horizontal
@doutriaux1 doutriaux1 modified the milestone: 2.10 May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants