New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NC_String type for netCDF file attributes #7

Closed
dnadeau4 opened this Issue Sep 20, 2016 · 9 comments

Comments

Projects
None yet
2 participants
@dnadeau4
Contributor

dnadeau4 commented Sep 20, 2016

From @dnadeau4 on May 20, 2016 0:33

Copied from original issue: CDAT/cdat/pull/1984

@dnadeau4

This comment has been minimized.

Contributor

dnadeau4 commented Sep 20, 2016

From @doutriaux1 on May 23, 2016 16:15

@dnadeau4 do you mind adding a test please. Thanks

@dnadeau4

This comment has been minimized.

Contributor

dnadeau4 commented Sep 20, 2016

Created test_ncString.py for netCDF String attribute.

@dnadeau4

This comment has been minimized.

Contributor

dnadeau4 commented Sep 20, 2016

From @sankhesh on June 9, 2016 15:4

Buildbot Dashboards

Gitlab

CDash

@dnadeau4

This comment has been minimized.

Contributor

dnadeau4 commented Sep 20, 2016

From @doutriaux1 on June 29, 2016 17:33

@dnadeau4 it seems to break a few test:
https://open.cdash.org/viewTest.php?onlyfailed&buildid=4434141

@dnadeau4

This comment has been minimized.

Contributor

dnadeau4 commented Sep 20, 2016

Did you change some input files? The shapes are different.

I'll try cdms2 on Anaconda on my box.

Denis

On 6/29/16 10:33 AM, Charles Doutriaux wrote:

@dnadeau4 https://github.com/dnadeau4 it seems to break a few test:
https://open.cdash.org/viewTest.php?onlyfailed&buildid=4434141


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
CDAT/cdat#1984 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AGnMgiK5aXXh_4Afk-UzDTcPNd3_Jk34ks5qQqyDgaJpZM4Iiyyd.

@dnadeau4

This comment has been minimized.

Contributor

dnadeau4 commented Sep 20, 2016

From @sankhesh on August 4, 2016 15:23

Do: test

@dnadeau4

This comment has been minimized.

Contributor

dnadeau4 commented Sep 20, 2016

From @cdatrobot on August 4, 2016 15:23

Basic content checks failed!

commit 7bd76dd4 adds bad whitespace:
testing/cdms2/CMakeLists.txt:111: trailing whitespace.
+    ${cdat_SOURCE_DIR}/testing/cdms2/test_ncString.py 

commit bbe10d72 has committer name "GitHub" with no space.  Run
  git config --global user.name 'Your Name'
  git config --global user.email 'you@yourdomain.com'
before creating commits.
commit 8a02e8a7 has committer name "GitHub" with no space.  Run
  git config --global user.name 'Your Name'
  git config --global user.email 'you@yourdomain.com'
before creating commits.
commit 6f5ddbd0 has committer name "GitHub" with no space.  Run
  git config --global user.name 'Your Name'
  git config --global user.email 'you@yourdomain.com'
before creating commits.
commit 52283cbd adds bad whitespace:
testing/cdms2/test_ncString.py:16: new blank line at EOF.

Branch-at: 7bd76dd4a26e5da4a948c59d9342fd6d3431e794
Rejected-by: @llnlbot

@dnadeau4

This comment has been minimized.

Contributor

dnadeau4 commented Sep 20, 2016

From @doutriaux1 on September 20, 2016 20:11

@dnadeau4 please finish and re-open on cdms repo thx!

@dnadeau4

This comment has been minimized.

Contributor

dnadeau4 commented Jan 13, 2017

@doutriaux1 can you merge my pull request #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment