New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 149 string attribute issue #150

Merged
merged 4 commits into from Aug 7, 2017

Conversation

Projects
None yet
3 participants
@dnadeau4
Contributor

dnadeau4 commented Aug 2, 2017

Fix #149

dnadeau4 added some commits Aug 3, 2017

@dnadeau4 dnadeau4 self-assigned this Aug 4, 2017

@dnadeau4 dnadeau4 added the enhancement label Aug 4, 2017

@dnadeau4 dnadeau4 added this to the 2.12 milestone Aug 4, 2017

@durack1

This comment has been minimized.

Member

durack1 commented Aug 7, 2017

@dnadeau4 @doutriaux1 or even better a nightly which includes the changes both in #150 (this) and #139 (GPCP) so both examples can be tested out together

@doutriaux1 doutriaux1 merged commit c4f4e30 into master Aug 7, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the issue149_stringattr branch Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment