Skip to content

Issue 153 cross section #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 10, 2017
Merged

Issue 153 cross section #154

merged 6 commits into from
Aug 10, 2017

Conversation

doutriaux1
Copy link
Contributor

fix #153

@doutriaux1 doutriaux1 mentioned this pull request Aug 9, 2017
Closed
@doutriaux1
Copy link
Contributor Author

@zshaheen @chengzhuzhang please review

@zshaheen
Copy link
Contributor

zshaheen commented Aug 9, 2017

@doutriaux1

As per our Jabber conversation, here's how it looks like with the latest code on this PR.

screen shot 2017-08-09 at 10 08 04 am

@zshaheen
Copy link
Contributor

zshaheen commented Aug 9, 2017

@doutriaux1
Also, running cdutil.averager(diff, axis='yz', weights='generate') to get the metrics breaks as well, only on the diff and not the reference or test.

@chengzhuzhang
Copy link

Great Job @doutriaux1 and @zshaheen !!

@doutriaux1 doutriaux1 mentioned this pull request Aug 9, 2017
Closed
@doutriaux1
Copy link
Contributor Author

screen shot 2017-08-09 at 10 46 43 am

@doutriaux1 doutriaux1 merged commit eebd9c0 into master Aug 10, 2017
@doutriaux1 doutriaux1 deleted the issue_153_crossSection branch August 10, 2017 14:18
@doutriaux1 doutriaux1 added this to the 2.12 milestone Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12
Development

Successfully merging this pull request may close these issues.

Undefined local variable with regrid2.crossSection.get_latitude_wts_bnds
3 participants
@doutriaux1 @zshaheen @chengzhuzhang