Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced numpy.rank() with numpy.ndim(), adding test_setdimattribute* #387

Merged
merged 1 commit into from Feb 6, 2020

Conversation

muryanto1
Copy link
Member

@muryanto1 muryanto1 commented Feb 5, 2020

No description provided.

@muryanto1 muryanto1 requested a review from jasonb5 Feb 5, 2020
jasonb5
jasonb5 approved these changes Feb 5, 2020
Copy link
Contributor

@jasonb5 jasonb5 left a comment

Looks good.

@muryanto1 muryanto1 merged commit 34cec4f into master Feb 6, 2020
7 checks passed
@muryanto1
Copy link
Member Author

muryanto1 commented Feb 6, 2020

This is for fixing #384

@muryanto1 muryanto1 deleted the fixes_for_numpy_1.18 branch Feb 26, 2020
@jasonb5 jasonb5 added this to the 8.2.1 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

While importing cdms2 error pops up: ImportError: cannot import name 'rank'
2 participants