Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue78 strvar #89

Merged
merged 6 commits into from Feb 21, 2017
Merged

Issue78 strvar #89

merged 6 commits into from Feb 21, 2017

Conversation

dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Feb 14, 2017

Now allow to read "NC_STRING" variables. test_allMIPs.py

@durack1
Copy link
Member

durack1 commented Feb 14, 2017

@dnadeau4 great! Does this PR provide read AND write for string variables, or just read?

@@ -58,9 +58,9 @@
mpicc="mpicc"
subprocess.check_call([mpicc,"--version"])
os.environ["CC"]=mpicc
os.environ["CFLAGS"]="-w -g"
os.environ["CFLAGS"]="-w -g -O0"
Copy link
Contributor

@doutriaux1 doutriaux1 Feb 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really want -O0?

Copy link
Contributor Author

@dnadeau4 dnadeau4 Feb 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we have -g, -O0 helps for not optimizing some local variables, especially counter like i,j. Otherwise, they are optimized and we can't access their value. We should really get rid for -g -O0 when we distribute to make the program go faster.

@dnadeau4
Copy link
Contributor Author

dnadeau4 commented Feb 21, 2017

@doutriaux1 merge?

@doutriaux1 doutriaux1 merged commit f5cde4d into master Feb 21, 2017
@doutriaux1 doutriaux1 deleted the issue78_STRVAR branch Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants