Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is monthly cal bug #7

Merged
merged 7 commits into from May 2, 2017
Merged

Is monthly cal bug #7

merged 7 commits into from May 2, 2017

Conversation

doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Feb 21, 2017

@dnadeau4 ready to review

@dnadeau4
Copy link
Contributor

dnadeau4 commented Feb 21, 2017

No test?

@dnadeau4
Copy link
Contributor

dnadeau4 commented Mar 22, 2017

@doutriaux1 can you write a quick test? I'd like to see a green light 🚥

@@ -135,12 +135,11 @@ def isMonthly(s):
units=tim.units
monthly=1
for i in range(len(tim)-1):
month1=cdtime.reltime(tim[i],units).torel('months since 2000').value
month2=cdtime.reltime(tim[i+1],units).torel('months since 2000').value
month1=cdtime.reltime(tim[i],units).torel('months since 2000',tim.getCalendar()).value
Copy link
Member

@durack1 durack1 Mar 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doutriaux1 glad to see that you have fallen into line and are now importing using 3-letter acronyms

Copy link
Contributor Author

@doutriaux1 doutriaux1 Mar 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@durack1 there's no 3 letters import here.

Copy link
Member

@durack1 durack1 Mar 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@doutriaux1 my mistake, the 3 letter variable tim=s.getTime()

@doutriaux1 doutriaux1 merged commit f021bc8 into master May 2, 2017
@doutriaux1 doutriaux1 deleted the isMonthly_cal_bug branch May 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants