Is monthly cal bug #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doutriaux1
force-pushed
the
isMonthly_cal_bug
branch
from
581a052
to
81fca4d
Compare
|
No test? |
|
@doutriaux1 can you write a quick test? I'd like to see a green light 🚥 |
durack1
reviewed
Mar 22, 2017
| @@ -135,12 +135,11 @@ def isMonthly(s): | |||
| units=tim.units | |||
| monthly=1 | |||
| for i in range(len(tim)-1): | |||
| month1=cdtime.reltime(tim[i],units).torel('months since 2000').value | |||
| month2=cdtime.reltime(tim[i+1],units).torel('months since 2000').value | |||
| month1=cdtime.reltime(tim[i],units).torel('months since 2000',tim.getCalendar()).value | |||
There was a problem hiding this comment.
@doutriaux1 glad to see that you have fallen into line and are now importing using 3-letter acronyms
There was a problem hiding this comment.
@durack1 there's no 3 letters import here.
There was a problem hiding this comment.
@doutriaux1 my mistake, the 3 letter variable tim=s.getTime()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dnadeau4 ready to review