Skip to content

Fix percentile bug#40

Merged
muryanto1 merged 15 commits into
masterfrom
fix_percentile_bug
Jul 11, 2020
Merged

Fix percentile bug#40
muryanto1 merged 15 commits into
masterfrom
fix_percentile_bug

Conversation

@jasonb5

@jasonb5 jasonb5 commented Jul 3, 2020

Copy link
Copy Markdown
Contributor

Fix for #38

  • Fixes passing 1d array as input to percentiles.
  • Fixes error when axis is out of bounds for input data.
  • Adds unittests for percentile function.
  • Migrates numpy.rank to numpy.ndim.

There's a divide by zero error that still needs to be fixed.

@jasonb5 jasonb5 requested a review from muryanto1 July 3, 2020 07:28
@jasonb5 jasonb5 marked this pull request as draft July 3, 2020 07:29
@jasonb5

jasonb5 commented Jul 8, 2020

Copy link
Copy Markdown
Contributor Author

@muryanto1 I just need to fix the Makefile dev-environment then we should be good to merge.

Comment thread Makefile
@muryanto1 muryanto1 marked this pull request as ready for review July 11, 2020 22:02
@muryanto1 muryanto1 merged commit 696cf33 into master Jul 11, 2020
@jasonb5 jasonb5 linked an issue Jul 27, 2020 that may be closed by this pull request
@muryanto1 muryanto1 added this to the 8.2.1 milestone Jul 28, 2020
@muryanto1 muryanto1 deleted the fix_percentile_bug branch August 5, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error in genutils.statistics.percentiles

3 participants