Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix percentile bug #40

Merged
merged 15 commits into from Jul 11, 2020
Merged

Fix percentile bug #40

merged 15 commits into from Jul 11, 2020

Conversation

jasonb5
Copy link
Contributor

@jasonb5 jasonb5 commented Jul 3, 2020

Fix for #38

  • Fixes passing 1d array as input to percentiles.
  • Fixes error when axis is out of bounds for input data.
  • Adds unittests for percentile function.
  • Migrates numpy.rank to numpy.ndim.

There's a divide by zero error that still needs to be fixed.

@jasonb5 jasonb5 requested a review from muryanto1 Jul 3, 2020
@jasonb5 jasonb5 marked this pull request as draft Jul 3, 2020
@jasonb5
Copy link
Contributor Author

jasonb5 commented Jul 8, 2020

@muryanto1 I just need to fix the Makefile dev-environment then we should be good to merge.

Makefile Show resolved Hide resolved
@muryanto1 muryanto1 marked this pull request as ready for review Jul 11, 2020
@muryanto1 muryanto1 merged commit 696cf33 into master Jul 11, 2020
24 checks passed
@jasonb5 jasonb5 linked an issue Jul 27, 2020 that may be closed by this pull request
@muryanto1 muryanto1 added this to the 8.2.1 milestone Jul 28, 2020
@muryanto1 muryanto1 deleted the fix_percentile_bug branch Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in genutils.statistics.percentiles
2 participants