manageElements.py setLineAttributes doesn't work

This function isn't currently working.
The issue seems to be that it's setting to.linetype, to.linewidth, and to.linecolor when the attributes that to has are linetypes, linewidths, linecolors.
From conversation with @chaosphere2112 it appears to should be a isoline, 1d, or vector object.
I'll work on a patch and submit a PR when I get it working.

def setLineAttributes(to, l):
    """
    Set attributes linecolor, linewidth and linetype from line l.
    l can be a line name defined in vcs.elements or a line object

    :Example:

        .. doctest:: manageElements_setLineAttributes

            >>> vcs.show('line')
            *******************Line Names List**********************
            ...
            *******************End Line Names List**********************
            >>> new_isoline=vcs.createisoline()
            >>> vcs.setLineAttributes(new_isoline, 'continents')

    :param to:
    :param l:
    :return:
    """
    import queries
    line = None
    if (queries.isline(l)):
        line = l
    elif l in vcs.elements["line"]:
        line = vcs.elements["line"][l]
    else:
        raise ValueError("Expecting a line object or a " +
                         "line name defined in vcs.elements, got type " +
                         type(l).__name__)
    to.linecolor = line.color[0]
    to.linewidth = line.width[0]
    to.linetype = line.type[0]

[doutriaux1]

@embrown what is calling this? I think @danlipsa impletmented this for isoline object, not line object. Is that correct @danlipsa

@doutriaux1 I was trying to call it in a doctest example. It looks like it works for setting the properties of a vector or 1d. It would have to be tweaked just slightly to be able to set the properties of an isoline.
If it's not supposed to set the properties of an isoline, then I won't do it. It's working fine for 1d and vector.

This is the example.
If I change the isoline to a vector, then this works. I had talked to Sam and he thought it should work for an isoline as well, which is why I submitted the issue.

>>> vcs.show('line')
*******************Line Names List**********************
...
*******************End Line Names List**********************
>>> new_isoline=vcs.createisoline('new_iso')
>>> vcs.setLineAttributes(new_isoline, 'continents')

@doutriaux1 should this function handle the case where to is an isoline?

[doutriaux1]

I think so because we used to be able to do the following and it's broken now:

In [4]: iso.line = "continents"
DEPRECATED: Use linetypes or setLineAttributes instead.
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-4-194eb5441c69> in <module>()
----> 1 iso.line = "continents"

/Users/doutriaux1/anaconda2/envs/v2.8/lib/python2.7/site-packages/vcs/isoline.pyc in _setline(self, value)
    736     def _setline(self, value):
    737         print 'DEPRECATED: Use linetypes or setLineAttributes instead.'
--> 738         self.setLineAttributes(value)
    739 
    740     line = property(_getline, _setline)

/Users/doutriaux1/anaconda2/envs/v2.8/lib/python2.7/site-packages/vcs/isoline.pyc in setLineAttributes(self, mixed)
    774                 raise ValueError("Expecting a line object or " +
    775                                  "a line name defined in in " +
--> 776                                  "vcs.elements, got type %s" % type(l).__name__)
    777             types.append(line.type[0])
    778             colors.append(line.color[0])

ValueError: Expecting a line object or a line name defined in in vcs.elements, got type str

In [5]: iso.line = vcs.elements["line"]["continents"]
DEPRECATED: Use linetypes or setLineAttributes instead.
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-5-664248264eae> in <module>()
----> 1 iso.line = vcs.elements["line"]["continents"]

/Users/doutriaux1/anaconda2/envs/v2.8/lib/python2.7/site-packages/vcs/isoline.pyc in _setline(self, value)
    736     def _setline(self, value):
    737         print 'DEPRECATED: Use linetypes or setLineAttributes instead.'
--> 738         self.setLineAttributes(value)
    739 
    740     line = property(_getline, _setline)

/Users/doutriaux1/anaconda2/envs/v2.8/lib/python2.7/site-packages/vcs/isoline.pyc in setLineAttributes(self, mixed)
    749         colors = []
    750         widths = []
--> 751         for i, l in enumerate(mixed):
    752             # first try a line type
    753             try:

TypeError: 'Tl' object is not iterable

I fixed manageElements.setLineAttributes() to set an isoline's properties from a line, but I still get the 'Tl' object is not iterable error when I try to assign an isoline's line property to vcs.elements["line"]["continents"]

[doutriaux1]

fixed in master