New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meshfill broken #135

Closed
doutriaux1 opened this Issue Mar 1, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Mar 1, 2017

@sankhesh your commit 5f393f1 introduced the bug.

Please to reproduce run test:

(2.8) doutriaux1@maryam:[vcs]:[9635]> python /git/uvcdat/testing/vcs/test_vcs_plot_unstructured_via_boxfill.py fdfdf
Traceback (most recent call last):
  File "/git/uvcdat/testing/vcs/test_vcs_plot_unstructured_via_boxfill.py", line 6, in <module>
    x.plot(s,bg=1)
  File "/Users/doutriaux1/anaconda2/envs/2.8/lib/python2.7/site-packages/vcs/Canvas.py", line 2564, in plot
    a = self.__plot(arglist, keyargs)
  File "/Users/doutriaux1/anaconda2/envs/2.8/lib/python2.7/site-packages/vcs/Canvas.py", line 3893, in __plot
    returned_kargs = self.backend.plot(*arglist, **keyargs)
  File "/Users/doutriaux1/anaconda2/envs/2.8/lib/python2.7/site-packages/vcs/VTKPlots.py", line 607, in plot
    vtk_backend_grid, vtk_backend_geo, **kargs))
  File "/Users/doutriaux1/anaconda2/envs/2.8/lib/python2.7/site-packages/vcs/vcsvtk/pipeline2d.py", line 317, in plot
    self._plotInternal()
  File "/Users/doutriaux1/anaconda2/envs/2.8/lib/python2.7/site-packages/vcs/vcsvtk/meshfillpipeline.py", line 186, in _plotInternal
    c = self.getColorIndexOrRGBA(_colorMap, tmpColors[ct][0])
IndexError: list index out of range
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 1, 2017

I recommend the fix to be implemented in branch: migrate_test_suite
the tests that exhibit this bug are in directory: tests/failing

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 1, 2017

master has bugs that have been introduced by @chaosphere2112 PR #131

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 6, 2017

@sankhesh any progress on this?

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Mar 6, 2017

@doutriaux1 I haven't had a chance to look into this yet. If its not urgent, mind if I look into it tomorrow? Thanks!

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 6, 2017

@sankhesh tomorrw is totally fine.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 9, 2017

@sankhesh we really need this in soon now!

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Mar 9, 2017

@doutriaux1 Working on this now.

sankhesh added a commit that referenced this issue Mar 10, 2017

@doutriaux1 doutriaux1 modified the milestone: 2.10 May 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment