Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc strings PR introduced bug in test suite #136

Closed
doutriaux1 opened this issue Mar 1, 2017 · 3 comments
Closed

doc strings PR introduced bug in test suite #136

doutriaux1 opened this issue Mar 1, 2017 · 3 comments
Assignees
Labels
bug
Milestone

Comments

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Mar 1, 2017

Among others the following tests have been broken by @chaosphere2112 #131

test_vcs_user_passed_date.py

latitude labels are gone
test_vcs_user_passed_date

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Mar 2, 2017

@doutriaux1 What latitude labels are gone?

2.8 clean install:

2 8_raw

2.8 with master branch of VCS:

2 8_vcs_master

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Mar 2, 2017

Ah, nevermind; looks like ipython opened in the old environment. I see now, and will hunt this down.

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Mar 2, 2017

Got it.

This line in creategraphicsmethod()

elif gtype in ['boxfill', 'Gfb']:
        func = vcs.createboxfill

used to read

elif gtype in ['boxfill', 'default']:
        func = vcs.createboxfill

When it is that way, the desired behavior happens. This is almost definitely a bizarre bug internal to VCS, since the rest of the graphics methods all use "Gfm" or their proper graphics method names. I'll dig more into it tomorrow.

@danlipsa danlipsa closed this in c4c09f7 Mar 7, 2017
danlipsa added a commit that referenced this issue Mar 7, 2017
Patch for bug #136
danlipsa added a commit that referenced this issue Mar 28, 2017
@doutriaux1 doutriaux1 modified the milestone: 2.10 May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants