New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x.show('crap') could return a sorted list of valid options #139

Closed
jypeter opened this Issue Mar 8, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@jypeter

jypeter commented Mar 8, 2017

Just a very minor request for improvement. It would be nice the displayed list for Valid vcs elements below was alphabetically sorted. Just saying because I thought colormap was not in there and then I discovered it was the next to last element!

Maybe there are other places that could use alphabetical sorting

>>> x = vcs.init()
>>> x.show('crap')
[...]
Exception: Error: 'crap' is not a valid vcs element
Valid vcs elements are: ['list', 'projection', 'texttable', 'textorientation', 'textcombined', 'line', 'marker', 'fillarea', 'font', 'fontNumber', 'boxfill', 'isofill', 'isoline', 'meshfill', '3d_scalar', '3d_dual_scalar', '3d_vector', 'template', 'taylordiagram', '1d', 'vector', 'yxvsx', 'xyvsy', 'xvsy', 'scatter', 'colormap', 'display']


doutriaux1 added a commit that referenced this issue Mar 8, 2017

fix #139
Exception error is now sorted
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 8, 2017

@jypeter see: #141

@jypeter

This comment has been minimized.

jypeter commented Mar 9, 2017

Thanks!
I'll close this issue then. Though I don't know if it should be you or me closing it, or if you are supposed to wait till some tests pass

@jypeter jypeter closed this Mar 9, 2017

@doutriaux1 doutriaux1 reopened this Mar 9, 2017

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 9, 2017

@jypeter it will close when it's in master

@doutriaux1 doutriaux1 modified the milestone: 2.10 May 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment