New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs does not respect geometry on newer mac XCode 8.3 #147

Closed
doutriaux1 opened this Issue Mar 13, 2017 · 17 comments

Comments

Projects
None yet
4 participants
@doutriaux1
Member

doutriaux1 commented Mar 13, 2017

bg=1
geometry= {'width': 1200, 'height': 1091}

geometry not respected

Test file  : tests_png/test_vcs_1D_datawc_missing.png
Source file: uvcdat-testdata/baselines/vcs/test_vcs_1D_datawc_missing.png
Found Baselines:
- uvcdat-testdata/baselines/vcs/test_vcs_1D_datawc_missing.png
Comparing tests_png/test_vcs_1D_datawc_missing.png uvcdat-testdata/baselines/vcs/test_vcs_1D_datawc_missing.png ... ERROR: In /Users/doutriaux1/anaconda2/conda-bld/vtk-cdat_1484960149592/work/Imaging/Core/vtkImageDifference.cxx, line 555
vtkImageDifference (0x7f863fb22de0): ExecuteInformation: Input are not the same size.
 Input1 is: 0,599,0,545,0,0
 Input2 is: 0,1199,0,1090,0,0

@doutriaux1 doutriaux1 added the bug label Mar 13, 2017

@doutriaux1 doutriaux1 changed the title from vcs dies not respect geometry on newer mac XCode 8.3 to vcs does not respect geometry on newer mac XCode 8.3 Mar 13, 2017

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 14, 2017

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 14, 2017

great! Because the graphics look really really bad on my new macbook pro! Any ETA on this?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 14, 2017

@danlipsa want me to build this sha on my mac and let you guys know?

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 14, 2017

@doutriaux1 No, as it does not work yet. A VTK contributor works on this, as he knows macs best. I think he tries to make VTK work both in hi res and low res mode with low res being default - that is the default apple behaviour. We already have a solution to make it work only in hires.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 23, 2017

@doutriaux1 The fix for this issue has just been merged into master.

@danlipsa danlipsa closed this Mar 23, 2017

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 23, 2017

This is the SHA: dbb7f8cec7c02c896d0d6a617d0f2207e0fd4bf1

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 23, 2017

Awesome! Building it right now, will let you know!

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 23, 2017

@danlipsa okay this is better, a few things are still borken

import vcs
x=vcs.init()
x.plot([1,2,3])

opens the tiniest window ever

z=vcs.init()
z.open()
z.plot(s)
z.clear()
z.close()
z.plot(s)

leads to a picture with a red background
red

@doutriaux1 doutriaux1 reopened this Mar 23, 2017

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 24, 2017

@doutriaux1 @aashish24 This sequence where you plot after close() does not work very well on linux either - I end up with a black background. I filed a new issue for it:
#154
I can take a look at this if we think is important.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 24, 2017

@doutriaux1 Your first example with x.plot([1,2,3]) works fine on my mac book pro. Are you sure there isn't a configuration error. It does not make sense why certain windows would be OK and others would not.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 24, 2017

@danlipsa this on the newer mac with sierra and xcode 8.3.
@danlipsa I can;t get your sha1 (or master) to compile on any mac Xcode 7 or 8

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 24, 2017

example of what i get currently:

Compiling '/Users/doutriaux1/anaconda3/conda-bld/vtk-cdat_1490373529642/work/build/Wrapping/Python/twisted/words/protocols/jabber/sasl_mechanisms.py'...
Compiling '/Users/doutriaux1/anaconda3/conda-bld/vtk-cdat_1490373529642/work/build/Wrapping/Python/twisted/words/protocols/jabber/xmlstream.py'...
Compiling '/Users/doutriaux1/anaconda3/conda-bld/vtk-cdat_1490373529642/work/build/Wrapping/Python/twisted/words/protocols/jabber/xmpp_stringprep.py'...
***   File "/Users/doutriaux1/anaconda3/conda-bld/vtk-cdat_1490373529642/work/build/Wrapping/Python/twisted/words/protocols/jabber/xmpp_stringprep.py", line 136
    raise UnicodeError, "Invalid character %s" % repr(c)
                      ^
SyntaxError: invalid syntax
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 24, 2017

ooops I see the issue here this a python3

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 24, 2017

back in a few

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 27, 2017

@doutriaux1 Is this still a bug, now that you built the new VTK?

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Mar 28, 2017

@doutriaux1 @aashish24 There is still a problem with high res macs. You cannot have odd window dimensions if you open your app in high res (as all python apps are). Hopefully Sean McBride will fix this soon. See
https://gitlab.kitware.com/vtk/vtk/merge_requests/2567#note_237976

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Apr 25, 2017

@doutriaux1 @aashish24 There seems to be an intrinsic problem with macs and windows with odd sizes (see the last commend on the link on gitlab) @doutriaux1 fixed this by resizing all baselines to even sizes.

@danlipsa danlipsa closed this Apr 25, 2017

@doutriaux1 doutriaux1 modified the milestone: 2.10 May 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment