vcs.Gfb.rename() seems to destroy the object that it's renaming #2
Comments
|
@doutriaux1 I think I solved this problem. Want me to make a test and submit the new rename() code with a PR? |
|
@doutriaux1 PR submitted. Let me know if there's anything I need to change. |
doutriaux1
added a commit
that referenced
this issue
Feb 27, 2017
* Fixes #2, Gfb.rename(). Re-wrote to change ._name and pop old name from elements if not 'default'. Preserves original objects. * Working on vcs documentation again. * Trying to fix doctest strings * Trying to get testing to work * Fixing errors for tests * Working on a script to parse doctest output for error warnings * Running individual modules through doctest and processing output * Working on doctest_vcs.py * Working on doctest scripts * Working on improving doctest reporting * Added README.md with links to doctest logs * Fixed README to be markdown friendly * Fixed errors in manageElements. Added doctests. General formatting improvements. * Adding doctests where they are missing. Fixing doctest errors where applicable. General documentation formatting fixes. * Adding doctests/documentation where necessary. Ran doctests and updated logs. * Fixing/adding doctests * Added more examples/doctests to utils.py . Removed some modules from run_all_doctests.sh . Fixed xmldocs so it doesn't try to plot projections/templates. Started dv3d descriptions. * Tweaked doctest cleanup. Fixed manageElements doctests. * Organized doctest_info directory. Minor fixes in Canvas, colormap, and xmldocs. * Fixed reference to old branch in README.md * Docstring formatting. Doctest corrections. Changed Not Yet Implemented warning. * doctest_vcs.py now filters out private functions from the missing section of the log. * Fixed more docstring formatting issues. Make html now reports (almost) no errors. Re-ran doctests/logging. * Fixing up template. Deleted old file in scripts/ * Undocumented some internal functions to template. Added more template documentation. Working on documentation in various stages for other files. * Updating logs. * Fixed taylordiagram examples * Added example to mtics doc * Adding doctests to xmldocs: * Fixed doctests for ticlabels, exts * Refactored doctest_vcs.py and re-ran tests. * Working on extracting repetetive params to xmldocs. * Re-factored xmldocs formatting. Re-ran doctests and re-reported. * Added functionality to ignore certain regular expressions when parsing report output with doctest.py. Regular expressions can be added via commandline or ignore file. This will allow us to ignore 'missing' doctests for functions that don't need documentation, or for aspects of a module/class which are not functions that errantly get picked up by doctest.testmod. * Added an Index of VCS functions for the pdf output. Added docs/API/build_func_index.py to automatically check a list of modules/classes, get their non-private functions, and write the RST for linking to those functions in the documentation out to API/functions/$MODULE_NAME to create the functions index. Not all functions written out to the /rst files have been documented. * Added README.md to doctest_info directories briefly explaining what's in them and how to use it. Added an ignore directory to store files for using doctest_vcs.py's --ifile option. * Formatted :Example: sections to <=80 lines so they look better in pdf. Re-ran doctest_vcs.py to check functionality after some minor edits. * Removed Makefile call to old function * Adds doctest_info/ to .gitignore. Fixes some links. Adds documentation for dv3d (from documentation site). changes some xmldocs strings to use .format(). * Added '.. pragma: skip-doctest' statements in some places they are needed for vcs's test suite. Updated output for 3d graphics methods to match VCS's output. These will need to be changed after CDAT/dv3d#14 is resolved. * Added lots of '.. pragma: skip-doctest' and fixed some broken tests. * Added skip-doctest to some docstrings. * Standardized print statements for .list() * Added things to stop tests from breaking * Removed some unused files, fixed one context-dependent doctest
aashish24
added a commit
that referenced
this issue
Feb 28, 2017
* Fixes #2, Gfb.rename(). Re-wrote to change ._name and pop old name from elements if not 'default'. Preserves original objects. * Working on vcs documentation again. * Trying to fix doctest strings * Trying to get testing to work * Fixing errors for tests * Working on a script to parse doctest output for error warnings * Running individual modules through doctest and processing output * Working on doctest_vcs.py * Working on doctest scripts * Working on improving doctest reporting * Added README.md with links to doctest logs * Fixed README to be markdown friendly * Fixed errors in manageElements. Added doctests. General formatting improvements. * Adding doctests where they are missing. Fixing doctest errors where applicable. General documentation formatting fixes. * Adding doctests/documentation where necessary. Ran doctests and updated logs. * Fixing/adding doctests * Added more examples/doctests to utils.py . Removed some modules from run_all_doctests.sh . Fixed xmldocs so it doesn't try to plot projections/templates. Started dv3d descriptions. * Tweaked doctest cleanup. Fixed manageElements doctests. * Organized doctest_info directory. Minor fixes in Canvas, colormap, and xmldocs. * Fixed reference to old branch in README.md * Docstring formatting. Doctest corrections. Changed Not Yet Implemented warning. * doctest_vcs.py now filters out private functions from the missing section of the log. * Fixed more docstring formatting issues. Make html now reports (almost) no errors. Re-ran doctests/logging. * Fixing up template. Deleted old file in scripts/ * Undocumented some internal functions to template. Added more template documentation. Working on documentation in various stages for other files. * Updating logs. * Fixed taylordiagram examples * Added example to mtics doc * Adding doctests to xmldocs: * Fixed doctests for ticlabels, exts * Refactored doctest_vcs.py and re-ran tests. * Working on extracting repetetive params to xmldocs. * Re-factored xmldocs formatting. Re-ran doctests and re-reported. * Added functionality to ignore certain regular expressions when parsing report output with doctest.py. Regular expressions can be added via commandline or ignore file. This will allow us to ignore 'missing' doctests for functions that don't need documentation, or for aspects of a module/class which are not functions that errantly get picked up by doctest.testmod. * Added an Index of VCS functions for the pdf output. Added docs/API/build_func_index.py to automatically check a list of modules/classes, get their non-private functions, and write the RST for linking to those functions in the documentation out to API/functions/$MODULE_NAME to create the functions index. Not all functions written out to the /rst files have been documented. * Added README.md to doctest_info directories briefly explaining what's in them and how to use it. Added an ignore directory to store files for using doctest_vcs.py's --ifile option. * Formatted :Example: sections to <=80 lines so they look better in pdf. Re-ran doctest_vcs.py to check functionality after some minor edits. * Removed Makefile call to old function * Adds doctest_info/ to .gitignore. Fixes some links. Adds documentation for dv3d (from documentation site). changes some xmldocs strings to use .format(). * Added '.. pragma: skip-doctest' statements in some places they are needed for vcs's test suite. Updated output for 3d graphics methods to match VCS's output. These will need to be changed after CDAT/dv3d#14 is resolved. * Added lots of '.. pragma: skip-doctest' and fixed some broken tests. * Added skip-doctest to some docstrings. * Standardized print statements for .list() * Added things to stop tests from breaking * Removed some unused files, fixed one context-dependent doctest
doutriaux1
added a commit
that referenced
this issue
May 4, 2017
* Fixes #2, Gfb.rename(). Re-wrote to change ._name and pop old name from elements if not 'default'. Preserves original objects. * Fixes script() functions for: * boxfill.py * meshfill.py * isofill.py * textcombined.py * texttable.py * vector.py Every function had a reference to color which was expected to be float(old color format), except vector, whose .line property had changed to .linetype, which was causing an error. * Added test for script() fix * Fixed all script functions to produce valid python scripts. Tested to ensure that scriptrun() on the output scripts creates objects identical to those on which script() was called. * Removed old, bad script test * Update boxfill.py * flake8
doutriaux1
added a commit
that referenced
this issue
May 4, 2017
* Fixes #2, Gfb.rename(). Re-wrote to change ._name and pop old name from elements if not 'default'. Preserves original objects. * Fixes script() functions for: * boxfill.py * meshfill.py * isofill.py * textcombined.py * texttable.py * vector.py Every function had a reference to color which was expected to be float(old color format), except vector, whose .line property had changed to .linetype, which was causing an error. * Added test for script() fix * Fixed all script functions to produce valid python scripts. Tested to ensure that scriptrun() on the output scripts creates objects identical to those on which script() was called. * Removed old, bad script test * Update boxfill.py * flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
submitted by @embrown at:
CDAT/cdat#2116
The text was updated successfully, but these errors were encountered: