Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isofill levels #10

Merged
merged 4 commits into from Sep 30, 2016
Merged

Fix isofill levels #10

merged 4 commits into from Sep 30, 2016

Conversation

@danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Sep 26, 2016

No description provided.

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 26, 2016

@doutriaux1 @aashish24 Please review. Where do I commit the new png and nc for the new testfile as well as changes to uvcdat/CMakeLists.txt?

Loading

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 26, 2016

thanks @danlipsa please commit to the usual repo for baselines UV-CDAT/uvcdat-testdata and createa branch with this branch's name on the UVCDAT/uvcdat repo, that should trigger the test suite.

Loading

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 26, 2016

@doutriaux1 Thanks.
Here are the additional PR:
CDAT/uvcdat-testdata#155
CDAT/cdat#2124

Loading

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 26, 2016

@doutriaux1 @aashish24 The fix is the second commit. The first commit is identical to the one reversed.

Loading

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 27, 2016

@danlipsa in theory the code looks good to me. Basically you are setting some valid value to hidden points so that scalar range does not change. @doutriaux1 can you confirm if this fixes the issue for you?

Loading

@danlipsa
Copy link
Contributor Author

@danlipsa danlipsa commented Sep 27, 2016

@aashish24 That is right. I also remove the globalid attribute and then add it back because otherwise RemoveDeletedCells does not remove the globalid associated with the deleted cells.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants