New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve put png #12

Merged
merged 9 commits into from Oct 3, 2016

Conversation

Projects
None yet
3 participants
@doutriaux1
Member

doutriaux1 commented Sep 28, 2016

doutriaux1 added some commits Sep 27, 2016

png can now send offset in pixels rahter than % of pix size
png does not have to be scaled to fit height of canvas any more
default are set such as nothing changes for exisitng codes

@doutriaux1 doutriaux1 referenced this pull request Sep 28, 2016

Merged

Improve put png #2127

if units[:7].lower() == "percent":
xoff = width * xOffset / zoom / 200.
yoff = height * yOffset / zoom / 200.
elif units[:5].lower() == "pixels":

This comment has been minimized.

@danlipsa

danlipsa Sep 28, 2016

Contributor

Here you need 6 instead of 5 isn't it?

This comment has been minimized.

@doutriaux1

doutriaux1 Sep 28, 2016

Member

it is already fixed, I think you're looking at an older version, no?

@chaosphere2112 chaosphere2112 merged commit bcb8d33 into master Oct 3, 2016

@chaosphere2112 chaosphere2112 deleted the improve_put_png branch Oct 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment