BUG #26: If masking reduces the bounds of a dataset, plots look incom… #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Data and baselines: |
|
@doutriaux1 @aashish24 @sankhesh Please review. |
|
@doutriaux1 It turned out that what I thought was a bug in VTK was a feature. 😄 So no VTK update is required for this. |
sankhesh
suggested changes
Oct 27, 2016
| @@ -14,6 +14,25 @@ | |||
| import sys | |||
| import numbers | |||
|
|
|||
| _DEBUG_VTK = True | |||
There was a problem hiding this comment.
Shouldn't _DEBUG_VTK be set to False?
There was a problem hiding this comment.
@sankhesh Thanks, I will remove the debug code.
…plete. We use 'vtk_dataset_bounds_no_mask', the dataset bounds before masking instead of the dataset bounds for fitToViewport.
danlipsa
force-pushed
the
masked-dataset-bounds
branch
from
6dde1e0
to
0f98650
Compare
|
@doutriaux1 @aashish24 Ready to merge? |
|
i need to run the tests and look at it, sorry I'm on another project today. |
|
@danlipsa looks reasonable to me. |
aashish24
approved these changes
Nov 2, 2016
| @@ -596,8 +598,9 @@ def plot(self, data1, data2, template, gtype, gname, bg, *args, **kargs): | |||
| ren = kargs["renderer"] | |||
|
|
|||
| vtk_backend_grid = kargs.get("vtk_backend_grid", None) | |||
| vtk_dataset_bounds_no_mask = kargs.get("vtk_dataset_bounds_no_mask", None) | |||
There was a problem hiding this comment.
None is returned by default but I am okay with more specifics.
|
@sankhesh @doutriaux1 can we merge this branch? |
sankhesh
approved these changes
Nov 2, 2016
|
let me run it, sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…plete.
We use 'vtk_dataset_bounds_no_mask', the dataset bounds before masking
instead of the dataset bounds for fitToViewport.