Repository navigation
BUG #26: If masking reduces the bounds of a dataset, plots look incom… - #27
Conversation
|
Data and baselines: |
|
@doutriaux1 @aashish24 @sankhesh Please review. |
|
@doutriaux1 It turned out that what I thought was a bug in VTK was a feature. 😄 So no VTK update is required for this. |
sankhesh
left a comment
sankhesh
left a comment
There was a problem hiding this comment.
LGTM except the debug variable value
| import sys | ||
| import numbers | ||
|
|
||
| _DEBUG_VTK = True |
There was a problem hiding this comment.
Shouldn't _DEBUG_VTK be set to False?
There was a problem hiding this comment.
@sankhesh Thanks, I will remove the debug code.
…plete. We use 'vtk_dataset_bounds_no_mask', the dataset bounds before masking instead of the dataset bounds for fitToViewport.
6dde1e0 to
0f98650
Compare
|
@doutriaux1 @aashish24 Ready to merge? |
|
i need to run the tests and look at it, sorry I'm on another project today. |
|
@danlipsa looks reasonable to me. |
| ren = kargs["renderer"] | ||
|
|
||
| vtk_backend_grid = kargs.get("vtk_backend_grid", None) | ||
| vtk_dataset_bounds_no_mask = kargs.get("vtk_dataset_bounds_no_mask", None) |
There was a problem hiding this comment.
None is returned by default but I am okay with more specifics.
|
@sankhesh @doutriaux1 can we merge this branch? |
|
let me run it, sorry about that. |
4 participants
…plete.
We use 'vtk_dataset_bounds_no_mask', the dataset bounds before masking
instead of the dataset bounds for fitToViewport.