New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG #26: If masking reduces the bounds of a dataset, plots look incom… #27

Merged
merged 1 commit into from Nov 2, 2016

Conversation

Projects
None yet
4 participants
@danlipsa
Contributor

danlipsa commented Oct 26, 2016

…plete.

We use 'vtk_dataset_bounds_no_mask', the dataset bounds before masking
instead of the dataset bounds for fitToViewport.

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Oct 26, 2016

Data and baselines:
CDAT/uvcdat-testdata#159
Tests
CDAT/cdat#2134

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Oct 26, 2016

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Oct 26, 2016

@doutriaux1 It turned out that what I thought was a bug in VTK was a feature. 😄 So no VTK update is required for this.

@sankhesh

LGTM except the debug variable value

@@ -14,6 +14,25 @@
import sys
import numbers
_DEBUG_VTK = True

This comment has been minimized.

@sankhesh

sankhesh Oct 27, 2016

Contributor

Shouldn't _DEBUG_VTK be set to False?

This comment has been minimized.

@danlipsa

danlipsa Oct 27, 2016

Contributor

@sankhesh Thanks, I will remove the debug code.

BUG #26: If masking reduces the bounds of a dataset, plots look incom…
…plete.

We use 'vtk_dataset_bounds_no_mask', the dataset bounds before masking
instead of the dataset bounds for fitToViewport.

@danlipsa danlipsa force-pushed the masked-dataset-bounds branch from 6dde1e0 to 0f98650 Oct 27, 2016

@danlipsa

This comment has been minimized.

Contributor

danlipsa commented Oct 27, 2016

@doutriaux1 @aashish24 Ready to merge?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 27, 2016

i need to run the tests and look at it, sorry I'm on another project today.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 2, 2016

@danlipsa looks reasonable to me.

@@ -596,8 +598,9 @@ def plot(self, data1, data2, template, gtype, gname, bg, *args, **kargs):
ren = kargs["renderer"]
vtk_backend_grid = kargs.get("vtk_backend_grid", None)
vtk_dataset_bounds_no_mask = kargs.get("vtk_dataset_bounds_no_mask", None)

This comment has been minimized.

@aashish24

aashish24 Nov 2, 2016

Contributor

None is returned by default but I am okay with more specifics.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Nov 2, 2016

@sankhesh @doutriaux1 can we merge this branch?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Nov 2, 2016

let me run it, sorry about that.

@doutriaux1 doutriaux1 merged commit cf99af4 into master Nov 2, 2016

@doutriaux1 doutriaux1 deleted the masked-dataset-bounds branch Nov 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment