New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch : png compression level option from user #28

Merged
merged 1 commit into from Oct 27, 2016

Conversation

Projects
None yet
2 participants
@arulalant
Contributor

arulalant commented Oct 27, 2016

I added two lines which used to pass argument "compression" by the user to control compression level of out png file.
x.png('outfile.png', compression=0) # no compression

png compression level option from user
I added two lines which used to pass argument "compression" by the user to control compression level of out png file. 
x.png('outfile.png', compression=0) # no compression

@arulalant arulalant changed the title from png compression level option from user to patch : png compression level option from user Oct 27, 2016

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 27, 2016

thanks @arulalant is 5 the default currently (i.e. before your patch)?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Oct 27, 2016

yes I see that it is (http://www.vtk.org/doc/nightly/html/classvtkPNGWriter.html#a6c251888f7132567ad1789ff96934772)

Should we change the default to 0? @aashish24 @danlipsa what do you think?

@doutriaux1 doutriaux1 merged commit e18101a into CDAT:master Oct 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment