Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cdat logo #297

Merged
merged 5 commits into from Jan 11, 2018
Merged

Cdat logo #297

merged 5 commits into from Jan 11, 2018

Conversation

doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Jan 11, 2018

No description provided.

@doutriaux1
Copy link
Contributor Author

doutriaux1 commented Jan 11, 2018

@danlipsa @aashish24 I don't think this needs much review

@doutriaux1
Copy link
Contributor Author

doutriaux1 commented Jan 11, 2018

new blines at: CDAT/uvcdat-testdata#183

@durack1
Copy link
Member

durack1 commented Jan 11, 2018

@doutriaux1 looks neat.. We'll need to make sure that we're also pulling this across to other repos, I'm thinking the PCMDI/pcmdi_metrics#517 in particular

@danlipsa
Copy link
Contributor

danlipsa commented Jan 11, 2018

LGTM

@aashish24
Copy link
Contributor

aashish24 commented Jan 11, 2018

If okay I would change the name to cdat.png from logo.png (as logo is a very generic term) but I am fine either way. LGTM as well. I live the logo 👍

@doutriaux1
Copy link
Contributor Author

doutriaux1 commented Jan 11, 2018

@aashish24 it used to be named uvcdat.png I changed to something generic on purpose but I can rename no problem. Will do that.

@jypeter
Copy link
Member

jypeter commented Jan 11, 2018

I like the characters, but what are the partly connected dots inside the C supposed to mean? They look nice as well anyway!

@doutriaux1 doutriaux1 merged commit dbb34f3 into master Jan 11, 2018
@doutriaux1 doutriaux1 deleted the CDATLogo branch Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants