Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for fillarea concave. #319

Merged
merged 4 commits into from Feb 26, 2018
Merged

Test for fillarea concave. #319

merged 4 commits into from Feb 26, 2018

Conversation

danlipsa
Copy link
Contributor

@danlipsa danlipsa commented Feb 21, 2018

No description provided.

@danlipsa
Copy link
Contributor Author

danlipsa commented Feb 21, 2018

Goes with
CDAT/uvcdat-testdata#190

@danlipsa
Copy link
Contributor Author

danlipsa commented Feb 21, 2018

Fixes
#254

@doutriaux1
Copy link
Contributor

doutriaux1 commented Feb 21, 2018

Thanks @danlipsa this is great!

@danlipsa
Copy link
Contributor Author

danlipsa commented Feb 21, 2018

@doutriaux1 Not sure what's wrong with travis, circle seems fine.

@doutriaux1
Copy link
Contributor

doutriaux1 commented Feb 22, 2018

I know working on trying to get more info, all test seem to pass, yet travis says "no", might be a time limit.

@doutriaux1
Copy link
Contributor

doutriaux1 commented Feb 22, 2018

yep on mine i see:
The job exceeded the maximum time limit for jobs, and has been terminated.

@doutriaux1
Copy link
Contributor

doutriaux1 commented Feb 22, 2018

@danlipsa drop the make doctest lines in travis and it should be ok. We do not need them since it's ran on circleci anyway

@danlipsa
Copy link
Contributor Author

danlipsa commented Feb 22, 2018

@aashish24 @doutriaux1 @scottwittenburg I think this is ready

@doutriaux1 doutriaux1 merged commit 0aea5fb into master Feb 26, 2018
@doutriaux1 doutriaux1 deleted the fillarea branch Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants