Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some places where the truncation fix was missed #378

merged 1 commit into from Jan 8, 2019


Copy link

@scottwittenburg scottwittenburg commented Jan 8, 2019

This results in an improvement mostly in vertical positioning of border lines, but is needed to avoid truncation of floating point to int values. Now rounding is done before casting to int.

Copy link

coveralls commented Jan 8, 2019

Coverage Status

Coverage remained the same at 70.895% when pulling 94952c8 on fix-a-few-more-truncated-ints into f83696d on master.

@doutriaux1 doutriaux1 merged commit c8a8363 into master Jan 8, 2019
@doutriaux1 doutriaux1 deleted the fix-a-few-more-truncated-ints branch Jan 8, 2019
@doutriaux1 doutriaux1 added this to the 8.1 milestone Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants