Add support for the 'reference' attribute on the vector gm #389
Conversation
|
@danlipsa Can you take a look at this when you get a chance? My goal was to keep your code implementing the default behavior intact (choosing an appropriate size for the vector legend arrow), while also supporting the ping @aashish24 |
The 'reference' attribute has been available to read/write on the vector graphics method, but until now has not been implemented. Now, if it is set, the default behavior of choosing a sensible value for the arrow length based on the screen space availabe, text size, etc., will be overridden. Instead the arrow length will simply be chosen to match the reference attribute. Hence, this feature should be used with care, as it could result in a vector legend with either very large or very small reference arrow.
scottwittenburg
force-pushed
the
support-vector-reference-attribute
branch
from
c86a745
to
95cc8ef
Compare
|
+1. Looks good! |
There was a problem hiding this comment.
@scottwittenburg shouldn't we update the doc string to explain better what the NNormalize options really mean?
|
@doutriaux1 We definitely should, I was hoping that @aashish24 could eventually chime in since he wrote that code. And the commit message you pointed me to last week (or was it the one before) didn't make sense to me. |
removed restriction on libcdms and numpy
|
@danlipsa i limites this pr to mac py3 let's use it to test your work. I tried to up xcode but no luck on that end either |
|
@danlipsa. I would say ssh into this and try to do your manual build here against the python that was pulled. What do you think? |
|
@danlipsa ok so py36 works but not py37 so i think you'll need to manually build for py37. Sorry about that. |
The 'reference' attribute has been available to read/write on
the vector graphics method, but until now has not been implemented.
Now, if it is set, the default behavior of choosing a sensible value
for the arrow length based on the screen space availabe, text size,
etc., will be overridden. Instead the arrow length will simply be
chosen to match the reference attribute. Hence, this feature should
be used with care, as it could result in a vector legend with either
very large or very small reference arrow.