Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rtd again #406

merged 5 commits into from May 1, 2019

Rtd again #406

merged 5 commits into from May 1, 2019


Copy link

@scottwittenburg @danlipsa @jypeter this finally fixes readthedocs


The issue was that conda was taking too much memory (more than 1Gb!) to solve the full vcs dependencies.

In theory you shouldn't need vtk to import vcs anyway since one could choose another backend (I know there's only one) so the vtk dependency should come later. This is the first step toward true backend independence.

It is important since currently the docs are just incomplete for vcs on readthedocs.

Copy link

@scottwittenburg scottwittenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: This environment.yml was only used to generate the online documentation?

Otherwise: Looks good to me.

…if linux py3 passes, this saves credits when flake8 fails for example
Copy link
Contributor Author

@scottwittenburg yes only by readthe doc. Maybe i will rename it just to be safe.

Copy link

Coverage Status

Coverage remained the same at ?% when pulling 6dbfbe4 on rtd_again into da97786 on master.

@doutriaux1 doutriaux1 merged commit 5b9f17f into master May 1, 2019
@downiec downiec added this to the 8.2 milestone Oct 21, 2019
@downiec downiec modified the milestones: 8.2, 8.2.1 Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants