-
-
Notifications
You must be signed in to change notification settings - Fork 64
Fixed the accuracy of log1pf(float x) when x is small.
#516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,42 @@ | ||
| #include <math.h> | ||
|
|
||
| float log1pf(float x) | ||
| float log1pf(const float x) | ||
| { | ||
| return logf(1 + x); | ||
| #if 1 | ||
| /** | ||
| * 0x1.0p-12f: At least 12.0bits of precision | ||
| */ | ||
| if (fabsf(x) < 2.44140625e-4f /* 0x1.0p-12f */) { | ||
| return x; | ||
| } | ||
| #else | ||
| #if 0 | ||
| /** | ||
| * 0x1.0p-63f: Fast denormalized/small value check for Assembly | ||
| * `0.5f (x * x)` rounds to zero when `x` is less than +-2^-74. We can | ||
| * perform a quick denormal test by checking that bits 6 and 5 of the | ||
| * highest byte of the float are zero. This allows any float less than | ||
| * +-2^-63 to take the fast `return x` path, and allows later code to | ||
| * assume that `x` is neither denormal nor zero. | ||
| */ | ||
| if (fabsf(x) < 1.084202172e-19f /* 0x1.0p-63f */) { | ||
| return x; | ||
| } | ||
| #endif | ||
| /** | ||
| * 0x1.7p-8f: At least 16.0bits of precision | ||
| * 0x1.8p-8f: At least 15.8bits of precision | ||
| * 0x1.0p-8f: At least 15.0bits of precision | ||
| */ | ||
| if (fabsf(x) < 5.615234375e-3f /* 0x1.7p-8f */) { | ||
| /** | ||
| * 0.5f can be turned into a decrement of the exponent assuming that | ||
| * `x` is normalized. | ||
| */ | ||
| return x - 0.5f * (x * x); | ||
| } | ||
| #endif | ||
| return logf(x + 1.0f); | ||
| } | ||
|
|
||
| double log1p(double) __attribute__((alias("log1pf"))); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed or in the standard.