Fix vulnerability in communication with LDAP connector #2635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlamalp
approved these changes
Mar 24, 2020
tauceti2
approved these changes
Mar 24, 2020
- we need to properly escape some characters to prevent LDAP query injection - new method for escaping character was added - method was used for every input from outside (on searchString) - we need to use replace instead of replaceAll, because '\' and '$' could work in different meanings here
stavamichal
force-pushed
the
fixVulnerablityInLDAPBasedExtSources
branch
from
4ee5c02
to
48cb4ec
Compare
zlamalp
approved these changes
Mar 24, 2020
zlamalp
added a commit
that referenced
this pull request
Mar 24, 2020
…xtSources Fix vulnerability in communication with LDAP connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
injection