New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vertex istream operator #3172
Fix vertex istream operator #3172
Conversation
|
@mglisse Where is the implementation of |
It is in a weird place (Triangulation/IO but it should be in NewKernel_d if it exists at all). No time right now, I am traveling. |
This PR is the only thing that "blocks" CGAL-4.11.2. I will postpone it to CGAL-4.12.1, or later, so that I can release CGAL-4.11.2 and close that release branch. |
@mglisse commented on Jun 21, 2018, 3:00 PM GMT+2:
Marc, could you comment, now? |
Branch mglisse/NewKernel_d-istream-glisse ? |
Now it matches what os<<point_d does at least.
when a triangulation is cleared, a full cell is always created when adding the infinite vertex
There is an issue with the base branch of this PR:
|
e4f3227
to
a7a998c
Compare
@maxGimeno merged master some some reason. I removed that commit and we're back to 11 new commits. |
I merged master because I couldn't use the cgal root as a cgal dir. I guess the branch is older than the working header only mechanism, but I didn't think of it at the time. |
Let me know once the PR is ready to be integrated. |
Hi. Sorry I missed this discussion, but to be honest, I hardly remember anything about this, except the code was a bit messy and that I didn't spend much time on trying to clean it up. Thanks for the fixes. |
Successfully tested in 4.14-Ic-40. |
Reported on cgal-discuss.