Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface mesh topology shortest cycle #4602

Merged
merged 164 commits into from Apr 29, 2020
Merged

Surface mesh topology shortest cycle #4602

merged 164 commits into from Apr 29, 2020

Conversation

gdamiand
Copy link
Member

@gdamiand gdamiand commented Mar 27, 2020 •
edited by sloriot

Please use the following template to help us managing pull requests.

Summary of Changes

Add a method that computes the smallest non contractible cycle in the surface mesh topology package.

Release Management

TODO:

  • @sloriot Check if branch must be filtered (size + duplicated commits)

hoangvanthien and others added 30 commits January 7, 2020 18:04
@hoangvanthien
Find BFS spanning tree and find E_noncon
1fb4f9c
@hoangvanthien
Change darts_of_cell to one_dart_per_incident_cell
8698ac0
@hoangvanthien
Remove some private variables
ce77577
@hoangvanthien
Add BFS trace, index marks for vertices, and construct the cycle
99cb89e
@hoangvanthien
Free index marks
8cbe859
@hoangvanthien
Fix typo in function name: indices instead of indicies
7907a48
@hoangvanthien
Initializing value for ind should be done once
ea4c8a4
@hoangvanthien
Fix path tracing
7a6bc55
@hoangvanthien
Fix important bug: m_gmap type must be a reference.
007d3da
@hoangvanthien
Update following Damiand's comments
e4dcdec
@hoangvanthien
Use attributes for vertices, remove boolean marks
0171659
@hoangvanthien
Change Path type
3e39318
@hoangvanthien
Set up 2-attribute
d81d6ca
@hoangvanthien
Add Dijkstra algorithm
252ccba
@hoangvanthien
Update spanning tree and trace index after updating distance
0ca0b68
@hoangvanthien
Fix some bugs, change find_cycle params, add edge_width function, rev…
55e2026 
…ert vertex_visited
@hoangvanthien
Improve general performance, set up 1-attribute, fix correspondence i…
21b599d 
…ssue between original and copied map
@hoangvanthien
Remove some comments
5ba0fe4
@hoangvanthien
Update following Damiand and Rineau comment
6330f66
@hoangvanthien
Use reserve for vectors, fix some bugs
6b16786
@hoangvanthien
Add 3 examples
97fa397
@gdamiand
Update cmake for new examples in surface mesh topology
2cf2ba2
@hoangvanthien
Explicit speciliazation is not allowed in class
a97d60c
@hoangvanthien
Remove explicit specialization for find_spanning_tree
deee186
@hoangvanthien
Fix unsew example errors
b6652f0
@hoangvanthien
Make SNC work with Combinatorial_map and Surface_mesh
3fa7aae
@hoangvanthien
Rename Get_opposite to opposite
d03ae16
@gdamiand
Copy of CMap and GMap returns now handle instead of const_handle.
6125c86
@gdamiand
Copy of CMap and GMap returns now handle instead of const_handle.
345c17f
@gdamiand
Improve unsew_edgewidth_repeatedly example.
544922c
@sloriot
Copy link
Member

sloriot commented Apr 27, 2020

@gdamiand there are some .off that are added by this branch that are not used. Can I remove them?

@gdamiand
Copy link
Member Author

@gdamiand there are some .off that are added by this branch that are not used. Can I remove them?

If you want. They can be used by examples that take an off as input; but this is not mandatory...

@sloriot
Copy link
Member

sloriot commented Apr 27, 2020

namely:

Surface_mesh_topology/examples/Surface_mesh_topology/data/double-torus-2-a.off
Surface_mesh_topology/test/Surface_mesh_topology/data/double-torus-2-c.off
Surface_mesh_topology/test/Surface_mesh_topology/data/double-torus-2-d.off
Surface_mesh_topology/test/Surface_mesh_topology/data/elephant-with-holes.off
Surface_mesh_topology/test/Surface_mesh_topology/data/obj1.off
Surface_mesh_topology/test/Surface_mesh_topology/data/obj1-with-holes.off

@sloriot sloriot removed the TODO label Apr 28, 2020
@sloriot
Copy link
Member

sloriot commented Apr 28, 2020

For some reason there were some duplicated commits from the initial feature branch. I cleaned that + removed the file above. The diff with your branch (I pushed a backup copy on your remote gsoc2019-nccycles-thien_before_28042020_filtering) is limited to the files I removed.

@sloriot
Copy link
Member

sloriot commented Apr 28, 2020

I can merge the branch now if you have no more things to do in it. I'm still planning to look at the user manual before the release but I can open a dedicated issue for that.

@gdamiand
Copy link
Member Author

Ok @sloriot ; nothing more to do from my side. Thanks !

@sloriot sloriot added Accepted small feature Tested and removed pre-approved For pre-approved small features. After 15 days the feature will be accepted. Not yet approved The feature or pull-request has not yet been approved. Under Testing Work in progress labels Apr 29, 2020
@sloriot sloriot merged commit 2d3e126 into CGAL:master Apr 29, 2020
@sloriot sloriot deleted the gsoc2019-nccycles-thien branch April 29, 2020 07:10
@sloriot sloriot self-assigned this Apr 29, 2020
@sloriot
Copy link
Member

sloriot commented Apr 29, 2020

@gdamiand There hasn't been a news entry for the Surface mesh topology package. You should consider write one. See the lastest one here.

@gdamiand
Copy link
Member Author

@sloriot Something like that CGAL/cgal-web#6 ?

@sloriot sloriot added the gsoc label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sloriot sloriot sloriot left review comments

Assignees

@sloriot sloriot

@maxGimeno maxGimeno

Labels
Accepted small feature gsoc gsoc-2019 Merged_in_5.1 Small feature Tested
Projects
None yet
Milestone
5.1-beta1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gdamiand @sloriot @MaelRL @lrineau @maxGimeno @hoangvanthien @FrancisGipsa