Fix large immediate displacements for AUICGP / AUIPCC. #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is this related to #125 ? |
resistor
reviewed
Mar 31, 2025
Author
Yes, it’s the fix for that issue. |
Collaborator
|
If this isn't urgent, is it possible to wait to land this after clang-19 lands? |
resistor
approved these changes
Mar 31, 2025
Author
|
Sure. I think Adam is using this locally, I just didn’t want the fix to get lost. Please feel free to close this and fix it properly in 19. |
This is the same displacement check as used elsewhere, but I'm not sure that it's actually right. The previous one was nonsense because it was ignoring the shift.
resistor
force-pushed
the
fix-lld-big-global-displacement
branch
from
39d3b70 to
db65d98
Compare
resistor
pushed a commit
that referenced
this pull request
Apr 29, 2025
… (#128662) …471)" Reland llvm/llvm-project#128471 The Passes library was not linked in earlier.
resistor
pushed a commit
that referenced
this pull request
Apr 29, 2025
…PM (#128…" (#128819) Reverts llvm/llvm-project#128662 Still a link error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same displacement check as used elsewhere, but I'm not sure that it's actually right. The previous one was nonsense because it was ignoring the shift.