Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template validation #11

Merged
merged 8 commits into from May 13, 2019

Conversation

Projects
None yet
2 participants
@jacoblurye
Copy link
Collaborator

commented May 13, 2019

Progress towards: https://trello.com/c/CJGIJ9wf/371-write-spreadsheet-validator

  • refactors the cidc_schemas.prism module into the template_reader.XlTemplateReader class
  • adds tests for XlTemplateReader's validation functionality
  • splits out XlTemplateWriter into the template_writer module
  • adds a validate_template sub-command to the CLI
  • README updates (general notes on project structure, example usage of the validate_template command)

@jacoblurye jacoblurye requested a review from jim-bo May 13, 2019

@jim-bo

jim-bo approved these changes May 13, 2019

Copy link
Contributor

left a comment

(thumbs up). No comments on code structure and tests seem good.

@jacoblurye jacoblurye merged commit 2b6283f into master May 13, 2019

@jacoblurye jacoblurye deleted the template-validation branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.